diff --git a/app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js b/app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js index 5f1eb0dce7..9bfa4484b4 100644 --- a/app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js +++ b/app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js @@ -88,7 +88,7 @@ describe("Admin settings page", function () { cy.wait(2000); cy.go(-1); cy.get(adminsSettings.provisioning).within(() => { - cy.get(adminsSettings.businessTag) + cy.get(adminsSettings.enterpriseTag) .should("exist") .should("contain", "Enterprise"); }); diff --git a/app/client/cypress/locators/AdminsSettings.js b/app/client/cypress/locators/AdminsSettings.js index a4ded79085..28b04491e3 100644 --- a/app/client/cypress/locators/AdminsSettings.js +++ b/app/client/cypress/locators/AdminsSettings.js @@ -32,4 +32,5 @@ export default { provisioning: ".t--settings-category-provisioning", upgrageLeftPane: "[data-testid='t--enterprise-settings-category-item-be']", businessTag: "[data-testid='t--business-tag']", + enterpriseTag: "[data-testid='t--enterprise-tag']", }; diff --git a/app/client/src/ce/pages/AdminSettings/LeftPane.tsx b/app/client/src/ce/pages/AdminSettings/LeftPane.tsx index 57916852eb..e1b8acaa4a 100644 --- a/app/client/src/ce/pages/AdminSettings/LeftPane.tsx +++ b/app/client/src/ce/pages/AdminSettings/LeftPane.tsx @@ -9,15 +9,12 @@ import { import { adminSettingsCategoryUrl } from "RouteBuilder"; import { useParams } from "react-router"; import AnalyticsUtil from "utils/AnalyticsUtil"; -import { Icon, Tag, Text } from "design-system"; +import { Icon, Text } from "design-system"; import { useDispatch, useSelector } from "react-redux"; import { ReduxActionTypes } from "@appsmith/constants/ReduxActionConstants"; import { getCurrentUser } from "selectors/usersSelectors"; -import { - BUSINESS_TAG, - ENTERPRISE_TAG, - createMessage, -} from "@appsmith/constants/messages"; +import BusinessTag from "components/BusinessTag"; +import EnterpriseTag from "components/EnterpriseTag"; export const Wrapper = styled.div` flex-basis: ${(props) => props.theme.sidebarWidth}; @@ -159,13 +156,8 @@ export function Categories({ config?.icon && )} {config.title} - {config?.needsUpgrade && ( - - {createMessage( - config?.isEnterprise ? ENTERPRISE_TAG : BUSINESS_TAG, - )} - - )} + {config?.needsUpgrade && + (config?.isEnterprise ? : )} {showSubCategory && ( props.theme.homePage.leftPane.width}px); @@ -191,11 +183,7 @@ export function AuthPage({ authMethods }: { authMethods: AuthMethodType[] }) { renderAs="p" > {method.label}  - {method.needsUpgrade && ( - - {createMessage(BUSINESS_TAG)} - - )} + {method.needsUpgrade && } {method.isConnected && ( {
- - {createMessage(BUSINESS_TAG)} - + import("assets/images/email-not-configured.svg"), @@ -308,9 +307,7 @@ export function CustomRolesRamp() { {createMessage(CUSTOM_ROLE_TEXT)} - - {createMessage(BUSINESS_TAG)} - +
{createMessage(CUSTOM_ROLE_DISABLED_OPTION_TEXT)} diff --git a/app/client/src/components/BusinessTag.tsx b/app/client/src/components/BusinessTag.tsx new file mode 100644 index 0000000000..424c92b962 --- /dev/null +++ b/app/client/src/components/BusinessTag.tsx @@ -0,0 +1,26 @@ +import React from "react"; +import type { TagSizes } from "design-system"; +import { Tag } from "design-system"; +import { BUSINESS_TAG, createMessage } from "@appsmith/constants/messages"; + +const BusinessTag = ({ + classes = "", + size, +}: { + classes?: string; + size?: TagSizes; +}) => { + return ( + + {createMessage(BUSINESS_TAG)} + + ); +}; + +export default BusinessTag; diff --git a/app/client/src/components/EnterpriseTag.tsx b/app/client/src/components/EnterpriseTag.tsx new file mode 100644 index 0000000000..0203d3d44c --- /dev/null +++ b/app/client/src/components/EnterpriseTag.tsx @@ -0,0 +1,26 @@ +import React from "react"; +import type { TagSizes } from "design-system"; +import { Tag } from "design-system"; +import { ENTERPRISE_TAG, createMessage } from "@appsmith/constants/messages"; + +const EnterpriseTag = ({ + classes = "", + size, +}: { + classes?: string; + size?: TagSizes; +}) => { + return ( + + {createMessage(ENTERPRISE_TAG)} + + ); +}; + +export default EnterpriseTag; diff --git a/app/client/src/ee/sagas/analyticsSaga.ts b/app/client/src/ee/sagas/analyticsSaga.ts index b03dbf7e6b..45ea06e862 100644 --- a/app/client/src/ee/sagas/analyticsSaga.ts +++ b/app/client/src/ee/sagas/analyticsSaga.ts @@ -1 +1 @@ -export * from "../../ce/sagas/analyticsSaga"; +export * from "ce/sagas/analyticsSaga"; diff --git a/app/client/src/pages/Applications/EmbedSnippet/PrivateEmbeddingContent.tsx b/app/client/src/pages/Applications/EmbedSnippet/PrivateEmbeddingContent.tsx index d1e7b7adb4..aa1394e584 100644 --- a/app/client/src/pages/Applications/EmbedSnippet/PrivateEmbeddingContent.tsx +++ b/app/client/src/pages/Applications/EmbedSnippet/PrivateEmbeddingContent.tsx @@ -1,7 +1,6 @@ import React from "react"; -import { Text, Link, Button, Icon, Tag } from "design-system"; +import { Text, Link, Button, Icon } from "design-system"; import { - BUSINESS_TAG, createMessage, IN_APP_EMBED_SETTING, } from "@appsmith/constants/messages"; @@ -16,6 +15,7 @@ import { } from "utils/ProductRamps/RampsControlList"; import { useSelector } from "react-redux"; import { getRampLink, showProductRamps } from "selectors/rampSelectors"; +import BusinessTag from "components/BusinessTag"; function PrivateEmbeddingContent(props: { userAppPermissions: any[]; @@ -59,9 +59,7 @@ export function PrivateEmbedRampModal() { {createMessage(IN_APP_EMBED_SETTING.privateAppsText)} - - {createMessage(BUSINESS_TAG)} - + {setting.label} - {setting.needsUpgrade && ( - {createMessage(BUSINESS_TAG)} - )} + {setting.needsUpgrade && }