From d58692943405c01c0c75a44b125600b07d3eaee5 Mon Sep 17 00:00:00 2001 From: Rishabh Rathod Date: Wed, 2 Aug 2023 11:47:53 +0530 Subject: [PATCH] chore: Add JSLibrary autocomplete analytics (#25896) ## Description #### PR fixes following issue(s) Fixes #25281 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --- app/client/src/utils/autocomplete/CodemirrorTernService.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/client/src/utils/autocomplete/CodemirrorTernService.ts b/app/client/src/utils/autocomplete/CodemirrorTernService.ts index d244ea18d7..7fd2624c8c 100644 --- a/app/client/src/utils/autocomplete/CodemirrorTernService.ts +++ b/app/client/src/utils/autocomplete/CodemirrorTernService.ts @@ -399,6 +399,8 @@ class CodeMirrorTernService { selectedResultType: selected.type, isBestMatch: selectedResultIndex <= AutocompleteSorter.bestMatchEndIndex, + isExternalLibrary: selected.origin?.startsWith("LIB/"), + libraryNamespace: selected.origin?.split("/")[1], }); const hasParenthesis = selected.text.endsWith("()");