Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: allow all deleting in OPTION_INPUT control (#39587)

Browse Source 
/ok-to-test tags="@tag.Anvil"


https://github.com/user-attachments/assets/d2805978-7e58-4d59-9ccf-6774f67b961d



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added a configurable option in key-value controls that lets users
choose whether empty entries are allowed.
- Updated behavior for removing entries now adapts based on this
setting, offering more flexibility when managing list items and ensuring
a more intuitive user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13692124903>
> Commit: 783b98ca652d7cdd920b880c738b9273a4a7cb63
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13692124903&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Thu, 06 Mar 2025 06:10:39 UTC
<!-- end of auto-generated comment: Cypress test results  -->
This commit is contained in:
Pawan Kumar 2025-03-06 17:04:59 +05:30 committed by GitHub
parent ce75c7ed9c
commit cff531ab6f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/client/src/components/propertyControls/KeyValueComponent.tsx
View File

@ -56,6 +56,7 @@ interface KeyValueComponentProps {
pairs: SegmentedControlOption[]; pairs: SegmentedControlOption[];
updatePairs: UpdatePairFunction; updatePairs: UpdatePairFunction;
addLabel?: string; addLabel?: string;
allowEmpty?: boolean;
} }
type SegmentedControlOptionWithKey = SegmentedControlOption & { type SegmentedControlOptionWithKey = SegmentedControlOption & {
@ -223,8 +224,8 @@ export function KeyValueComponent(props: KeyValueComponentProps) {
/> />
<StyledBox /> <StyledBox />
<Button <Button
// At least one pair must be present // we don't want to allow deleting the only pair if allowEmpty is false
isDisabled={renderPairs.length <= 1} isDisabled={props.allowEmpty ? false : renderPairs.length <= 1}
isIconButton isIconButton
kind="tertiary" kind="tertiary"
onClick={(e: React.MouseEvent) => { onClick={(e: React.MouseEvent) => {

1
app/client/src/components/propertyControls/OptionControl.tsx
View File

@ -10,6 +10,7 @@ class OptionControl extends BaseControl<ControlProps> {
render() { render() {
return ( return (
<KeyValueComponent <KeyValueComponent
allowEmpty={this.props.controlConfig?.allowEmpty as boolean}
pairs={this.props.propertyValue} pairs={this.props.propertyValue}
updatePairs={this.updateOptions} updatePairs={this.updateOptions}
/> />