From ce81f3856daaee636707d14fc2c6f6124186ddbd Mon Sep 17 00:00:00 2001 From: Sumit Kumar Date: Mon, 17 Apr 2023 11:18:15 +0530 Subject: [PATCH] fix: fix oracle plugin info (#22432) ## Description - Update plugin name to `Oracle` from `Oracle plugin` - Update plugin icon Related to #20796 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --- .../server/migrations/DatabaseChangelog2.java | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/migrations/DatabaseChangelog2.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/migrations/DatabaseChangelog2.java index 018758127f..e92bcce889 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/migrations/DatabaseChangelog2.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/migrations/DatabaseChangelog2.java @@ -2812,12 +2812,12 @@ public class DatabaseChangelog2 { @ChangeSet(order = "042", id = "add-oracle-plugin", author = "") public void addOraclePlugin(MongoTemplate mongoTemplate) { Plugin plugin = new Plugin(); - plugin.setName("Oracle Plugin"); + plugin.setName("Oracle"); plugin.setType(PluginType.DB); plugin.setPackageName("oracle-plugin"); plugin.setUiComponent("DbEditorForm"); plugin.setResponseType(Plugin.ResponseType.TABLE); - plugin.setIconLocation("https://s3.us-east-2.amazonaws.com/assets.appsmith.com/oracle-db.jpg"); + plugin.setIconLocation("https://s3.us-east-2.amazonaws.com/assets.appsmith.com/oracle.png"); plugin.setDocumentationLink("https://docs.appsmith.com/datasource-reference/querying-oracle"); plugin.setDefaultInstall(true); try { @@ -2827,4 +2827,12 @@ public class DatabaseChangelog2 { } installPluginToAllWorkspaces(mongoTemplate, plugin.getId()); } + + @ChangeSet(order = "043", id = "update-oracle-plugin-name", author = "") + public void updateOraclePluginName(MongoTemplate mongoTemplate) { + Plugin oraclePlugin = mongoTemplate.findOne(query(where("packageName").is("oracle-plugin")), Plugin.class); + oraclePlugin.setName("Oracle"); + oraclePlugin.setIconLocation("https://s3.us-east-2.amazonaws.com/assets.appsmith.com/oracle.png"); + mongoTemplate.save(oraclePlugin); + } }