feat: extend datasource reconnect modal tooltip to include title (#28696)

> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Show tooltip when user hovers over datasource title or icon in
DatasourceReconnectModal. Previously, the tool tip only showed when the
icon was hovered over. This fixes that.
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes #28008 

#### Media

#### Type of change
> Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
Jacques Ikot 2023-11-15 03:09:29 +01:00 committed by GitHub
parent 3aece4ac29
commit ccb9a4c0eb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 12 deletions

View File

@ -79,7 +79,7 @@ describe("excludeForAirgap", "Fork a template to an workspace", () => {
.find(reconnectDatasourceLocators.ListItemIcon)
.should("be.visible");
cy.get(reconnectDatasourceLocators.DatasourceList)
.find(reconnectDatasourceLocators.ListItemIcon, {
.find(reconnectDatasourceLocators.DatasourceTitle, {
withinSubject: null,
})
.first()

View File

@ -6,4 +6,5 @@ export default {
ImportSuccessModalCloseBtn: ".t--import-success-modal-got-it",
ListItemIcon: ".ads-v2-icon",
DatasourceList: ".t--ds-list",
DatasourceTitle: ".t--ds-list-title",
};

View File

@ -76,15 +76,15 @@ function ListItemWrapper(props: {
>
<PluginImage alt="Datasource" src={getAssetUrl(plugin?.iconLocation)} />
<ListLabels>
<DsTitle>
<Text
className="t--ds-list-title"
color="var(--ads-v2-color-fg-emphasis)"
type={TextType.H4}
>
{ds.name}
</Text>
<Tooltip content={ds.name} placement="left">
<Tooltip content={ds.name} placement="left">
<DsTitle>
<Text
className="t--ds-list-title"
color="var(--ads-v2-color-fg-emphasis)"
type={TextType.H4}
>
{ds.name}
</Text>
<Icon
color={
isPluginAuthorized
@ -94,8 +94,8 @@ function ListItemWrapper(props: {
name={isPluginAuthorized ? "oval-check" : "info"}
size="md"
/>
</Tooltip>
</DsTitle>
</DsTitle>
</Tooltip>
<Text color="var(--ads-v2-color-fg)" type={TextType.H5}>
{plugin?.name}
</Text>