Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test: Fix page name test (#32825)

Browse Source 
Update test with the current page name validation rules on the server
and the client.

/ok-to-test tags="@tag.Settings"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8753150717>
> Commit: e322d185a0089662054672ec045596e67e055316
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8753150717&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated comments and test cases in Page Settings to reflect
restrictions on using slashes and colons in page names.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Shrikant Sharat Kandula 2024-04-19 17:59:03 +05:30 committed by GitHub
parent 272aad22cc
commit cca1b55daf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/client/cypress/e2e/Regression/ClientSide/SettingsPane/PageSettings_spec.ts
View File

@ -59,10 +59,10 @@ describe("Page Settings", { tags: ["@tag.Settings"] }, () => {
});
_.appSettings.ClosePane();
//Page name doesn't allow special character
// Page name doesn't allow slashes and colons
_.appSettings.OpenAppSettings();
_.appSettings.GoToPageSettings("Page3");
_.pageSettings.UpdatePageNameAndVerifyTextValue("Page3!@#", "Page3 ");
_.pageSettings.UpdatePageNameAndVerifyTextValue("Page3/\\:", "Page3");
_.appSettings.ClosePane();
// Page name doesn't allow empty