fix: increase scrolling threshold to fix weird scrolling behaviour (#25444)
## Description Widget scrolling was introduced in the context switching project to ensure that a selected widget is never out of view. This went through some changes and it seems like when widgets on edges increase height on interaction (select widget) or if the widget is longer than the current view, the scrolling behaviour did not make sense. To fix this problem, we have increased the threshold of scrolling, and will only scroll when less than 5% of the widget is visible on screen. Anything more and it will not scroll the page #### PR fixes following issue(s) Fixes #25146 #### Media https://github.com/appsmithorg/appsmith/assets/12022471/2cc251a3-01c9-44d8-9b6e-536e727250ec #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
parent
ff6c922718
commit
c7b551e328
|
|
@ -233,7 +233,7 @@ export const quickScrollToWidget = (
|
|||
const el = document.getElementById(widgetId);
|
||||
const canvas = document.getElementById("canvas-viewport");
|
||||
|
||||
if (el && canvas && !isElementVisibleInContainer(el, canvas)) {
|
||||
if (el && canvas && !isElementVisibleInContainer(el, canvas, 5)) {
|
||||
const scrollElement = getWidgetElementToScroll(widgetId, canvasWidgets);
|
||||
if (scrollElement) {
|
||||
scrollIntoView(scrollElement, {
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user