Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fixes (#522)

Browse Source 
- Remove cache fields from settings
- Call the event callback method with success false to fix button widget loading issue
This commit is contained in:
akash-codemonk 2020-09-10 11:05:45 +05:30 committed by GitHub
parent c1df5a95ac
commit c55a9214e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
app/client/src/mockResponses/ActionSettings.tsx
View File

@ -15,17 +15,17 @@ export const queryActionSettingsConfig = [
controlType: "SWITCH",
info: "Ask confirmation from the user everytime before refreshing data",
},
{
label: "Cache response",
configProperty: "shouldCacheResponse",
controlType: "SWITCH",
},
{
label: "Cache timeout (in milliseconds)",
configProperty: "cacheTimeout",
controlType: "INPUT_TEXT",
dataType: "NUMBER",
},
// {
// label: "Cache response",
// configProperty: "shouldCacheResponse",
// controlType: "SWITCH",
// },
// {
// label: "Cache timeout (in milliseconds)",
// configProperty: "cacheTimeout",
// controlType: "INPUT_TEXT",
// dataType: "NUMBER",
// },
{
label: "Query Timeout (in milliseconds)",
configProperty: "actionConfiguration.timeoutInMillisecond",
@ -53,17 +53,17 @@ export const apiActionSettingsConfig = [
controlType: "SWITCH",
info: "Ask confirmation from the user everytime before refreshing data",
},
{
label: "Cache response",
configProperty: "shouldCacheResponse",
controlType: "SWITCH",
},
{
label: "Cache timeout (in milliseconds)",
configProperty: "cacheTimeout",
controlType: "INPUT_TEXT",
dataType: "NUMBER",
},
// {
// label: "Cache response",
// configProperty: "shouldCacheResponse",
// controlType: "SWITCH",
// },
// {
// label: "Cache timeout (in milliseconds)",
// configProperty: "cacheTimeout",
// controlType: "INPUT_TEXT",
// dataType: "NUMBER",
// },
{
label: "Api Timeout (in milliseconds)",
configProperty: "actionConfiguration.timeoutInMillisecond",

3
app/client/src/sagas/ActionExecutionSagas.ts
View File

@ -289,6 +289,9 @@ export function* executeActionSaga(
if (api.confirmBeforeExecute) {
const confirmed = yield call(confirmRunActionSaga);
if (!confirmed) {
if (event.callback) {
event.callback({ success: false });
}
return;
}
}