Merge branch 'fix/action-selector-expected-value' into 'release'

Evaluated value bug fixes

- Show evaluated value for action creator text fields (message and url)
- Fix evaluated value crashing for chart data control

See merge request theappsmith/internal-tools-client!709
This commit is contained in:
Hetu Nandu 2020-06-11 11:03:17 +00:00
commit c4a03bc1f5
3 changed files with 7 additions and 3 deletions

View File

@ -195,7 +195,8 @@ const views = {
props.set(event);
}
}}
dataTreePath={""}
expected={"string"}
evaluatedValue={props.get(props.value, false) as string}
isValid={props.isValid}
errorMessage={props.validationMessage}
/>

View File

@ -81,7 +81,7 @@ function DataControlComponent(props: RenderComponentProps) {
updateOption(index, "seriesName", value);
},
}}
evaluatedValue={evaluated.seriesName}
evaluatedValue={evaluated?.seriesName}
theme={"DARK"}
singleLine={false}
placeholder="Series Name"
@ -113,7 +113,7 @@ function DataControlComponent(props: RenderComponentProps) {
updateOption(index, "data", value);
},
}}
evaluatedValue={evaluated.data}
evaluatedValue={evaluated?.data}
meta={{
error: isValid ? "" : "There is an error",
touched: true,

View File

@ -10,6 +10,7 @@ export function InputText(props: {
onChange: (event: React.ChangeEvent<HTMLTextAreaElement> | string) => void;
isValid: boolean;
errorMessage?: string;
evaluatedValue?: any;
expected?: string;
placeholder?: string;
dataTreePath?: string;
@ -22,6 +23,7 @@ export function InputText(props: {
onChange,
placeholder,
dataTreePath,
evaluatedValue,
} = props;
return (
<StyledDynamicInput>
@ -30,6 +32,7 @@ export function InputText(props: {
value: value,
onChange: onChange,
}}
evaluatedValue={evaluatedValue}
expected={expected}
dataTreePath={dataTreePath}
meta={{