diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ImportExportApplicationServiceCEImpl.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ImportExportApplicationServiceCEImpl.java index 1393043a97..a948d1be04 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ImportExportApplicationServiceCEImpl.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ImportExportApplicationServiceCEImpl.java @@ -333,7 +333,7 @@ public class ImportExportApplicationServiceCEImpl implements ImportExportApplica actionDTO.setCollectionId(collectionIdToNameMap.get(actionDTO.getCollectionId())); } - final String updatedActionId = actionDTO.getPageId() + "_" + actionDTO.getName(); + final String updatedActionId = actionDTO.getPageId() + "_" + actionDTO.getValidName(); actionIdToNameMap.put(newAction.getId(), updatedActionId); newAction.setId(updatedActionId); } @@ -347,7 +347,7 @@ public class ImportExportApplicationServiceCEImpl implements ImportExportApplica } if (!actionIdToNameMap.containsValue(newAction.getId())) { - final String updatedActionId = actionDTO.getPageId() + "_" + actionDTO.getName(); + final String updatedActionId = actionDTO.getPageId() + "_" + actionDTO.getValidName(); actionIdToNameMap.put(newAction.getId(), updatedActionId); newAction.setId(updatedActionId); } @@ -733,7 +733,7 @@ public class ImportExportApplicationServiceCEImpl implements ImportExportApplica .then(applicationService.save(importedApplication)); }) ) - .flatMap(savedAPP -> importThemes(savedAPP, importedDoc)) + .flatMap(savedApp -> importThemes(savedApp, importedDoc)) .flatMap(savedApp -> { importedApplication.setId(savedApp.getId()); if (savedApp.getGitApplicationMetadata() != null) { @@ -1146,7 +1146,7 @@ public class ImportExportApplicationServiceCEImpl implements ImportExportApplica // If pageId is missing in the actionDTO create a fallback pageId final String fallbackParentPageId = unpublishedAction.getPageId(); - if (unpublishedAction.getName() != null) { + if (unpublishedAction.getValidName() != null) { if (invisibleActionFieldsMap != null) { unpublishedAction.setUserSetOnLoad(invisibleActionFieldsMap.get(newAction.getId()).getUnpublishedUserSetOnLoad()); } @@ -1155,7 +1155,7 @@ public class ImportExportApplicationServiceCEImpl implements ImportExportApplica sanitizeDatasourceInActionDTO(unpublishedAction, datasourceMap, pluginMap, organizationId, false); } - if (publishedAction != null && publishedAction.getName() != null) { + if (publishedAction != null && publishedAction.getValidName() != null) { if (invisibleActionFieldsMap != null) { publishedAction.setUserSetOnLoad(invisibleActionFieldsMap.get(newAction.getId()).getPublishedUserSetOnLoad()); } @@ -1229,7 +1229,7 @@ public class ImportExportApplicationServiceCEImpl implements ImportExportApplica if (newAction.getUnpublishedAction() != null) { ActionDTO unpublishedAction = newAction.getUnpublishedAction(); actionIdMap.put( - actionIdMap.get(unpublishedAction.getName() + unpublishedAction.getPageId()), + actionIdMap.get(unpublishedAction.getValidName() + unpublishedAction.getPageId()), newAction.getId() ); @@ -1242,7 +1242,7 @@ public class ImportExportApplicationServiceCEImpl implements ImportExportApplica if (newAction.getPublishedAction() != null) { ActionDTO publishedAction = newAction.getPublishedAction(); actionIdMap.put( - actionIdMap.get(publishedAction.getName() + publishedAction.getPageId()), + actionIdMap.get(publishedAction.getValidName() + publishedAction.getPageId()), newAction.getId() ); @@ -1492,7 +1492,7 @@ public class ImportExportApplicationServiceCEImpl implements ImportExportApplica if (parentPage == null) { return null; } - actionIdMap.put(action.getName() + parentPage.getId(), action.getId()); + actionIdMap.put(action.getValidName() + parentPage.getId(), action.getId()); action.setPageId(parentPage.getId()); // Update defaultResources in actionDTO diff --git a/app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/ImportExportApplicationServiceTests.java b/app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/ImportExportApplicationServiceTests.java index 08741c038f..94f82529cc 100644 --- a/app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/ImportExportApplicationServiceTests.java +++ b/app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/ImportExportApplicationServiceTests.java @@ -544,6 +544,9 @@ public class ImportExportApplicationServiceTests { assertThat(unpublishedAction.getPageId()).isEqualTo(defaultPage.getUnpublishedPage().getName()); assertThat(unpublishedAction.getDatasource().getPluginId()).isEqualTo(installedPlugin.getPackageName()); + NewAction testAction1 = actionList.stream().filter(action -> action.getUnpublishedAction().getName().equals("testAction1")).findFirst().get(); + assertThat(testAction1.getId()).isEqualTo("Page1_testCollection1.testAction1"); + assertThat(actionCollectionList.isEmpty()).isFalse(); assertThat(actionCollectionList).hasSize(1); final ActionCollection actionCollection = actionCollectionList.get(0);