From c31fb9acd4c1902b79d1b8dacac90c64893be7df Mon Sep 17 00:00:00 2001 From: Arpit Mohan Date: Thu, 9 Jul 2020 18:53:13 +0530 Subject: [PATCH] Correcting the Github Action for the client Docker image build --- .github/workflows/client.yml | 4 ++-- app/client/README.md | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/client.yml b/.github/workflows/client.yml index 735ffe0641..ceb9740248 100644 --- a/.github/workflows/client.yml +++ b/.github/workflows/client.yml @@ -66,14 +66,14 @@ jobs: # Here, the GITHUB_REF is of type /refs/head/. We extract branch_name from this by removing the # first 11 characters. This can be used to build images for several branches - name: Get the version to tag the Docker image - id: vars + id: branch_name run: echo ::set-output name=tag::$(echo ${GITHUB_REF:11}) # Build release Docker image and push to Docker Hub - name: Push release image to Docker Hub if: success() && github.ref == 'refs/heads/release' run: | - docker build -t appsmith/appsmith-editor:${{steps.vars.outputs.tag}} . + docker build -t appsmith/appsmith-editor:${{steps.branch_name.outputs.tag}} . echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin docker push appsmith/appsmith-editor diff --git a/app/client/README.md b/app/client/README.md index dbbdec4dc2..80e0089a32 100755 --- a/app/client/README.md +++ b/app/client/README.md @@ -79,5 +79,3 @@ This section has moved here: https://facebook.github.io/create-react-app/docs/de ### `npm run build` fails to minify This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify - -