Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix: Comment icon gets hidden behind tabs on Tab widget (#11019)

Browse Source 
* fix for z-index issue on comments icon

* css changes

* fixed failing cypress tests
This commit is contained in:
Ankita Kinger 2022-02-12 08:28:13 +05:30 committed by GitHub
parent b778b83ac4
commit c29c2f745e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Comments/AddComments_spec.js
View File

@ -110,7 +110,7 @@ describe("Comments", function() {
// create another comment since the first one is a private bot thread // create another comment since the first one is a private bot thread
it("another comment can be created after dismissing the first one", () => { it("another comment can be created after dismissing the first one", () => {
cy.get(commonLocators.canvas).click(10, 10); cy.get(commonLocators.canvas).click(60, 10);
// wait for transition to be completed // wait for transition to be completed
// eslint-disable-next-line cypress/no-unnecessary-waiting // eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(300); cy.wait(300);
@ -137,8 +137,8 @@ describe("Comments", function() {
it("unread indicator is visible for another app user when a new comment is added", () => { it("unread indicator is visible for another app user when a new comment is added", () => {
// share app with TESTUSERNAME2 // share app with TESTUSERNAME2
cy.get(homePage.shareApp).click({ force: true }); cy.get(homePage.shareApp).click({ force: true });
cy.shareApp(Cypress.env("TESTUSERNAME2"), homePage.adminRole); cy.shareApp(Cypress.env("TESTUSERNAME1"), homePage.adminRole);
cy.LogintoApp(Cypress.env("TESTUSERNAME2"), Cypress.env("TESTPASSWORD2")); cy.LogintoApp(Cypress.env("TESTUSERNAME1"), Cypress.env("TESTPASSWORD1"));
// launch the editor // launch the editor
cy.get(homePage.searchInput).type(appName); cy.get(homePage.searchInput).type(appName);

2
app/client/src/comments/inlineComments/InlineCommentPin.tsx
View File

@ -38,7 +38,7 @@ const CommentTriggerContainer = styled.div<{
xOffset: number; xOffset: number;
yOffset: number; yOffset: number;
}>` }>`
position: absolute; position: fixed;
${(props) => getPosition(props)} ${(props) => getPosition(props)}
z-index: 1; z-index: 1;
`; `;

2
app/client/src/comments/inlineComments/UnpublishedCommentThread.tsx
View File

@ -28,7 +28,7 @@ const CommentTriggerContainer = styled.div<{
xOffset: number; xOffset: number;
yOffset: number; yOffset: number;
}>` }>`
position: absolute; position: fixed;
${(props) => getPosition(props)} ${(props) => getPosition(props)}
z-index: 1; z-index: 1;
& svg { & svg {