Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: Remove the table widget activation experiment (#27422)

Browse Source 
Removes the Table widget activation experiment introduced in #26257
This commit is contained in:
Hetu Nandu 2023-09-20 12:30:55 +05:30 committed by GitHub
parent 9d73501c7a
commit beb3b268f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/src/ce/entities/FeatureFlag.ts
View File

@ -16,7 +16,6 @@ export const FEATURE_FLAG = {
"release_table_serverside_filtering_enabled", "release_table_serverside_filtering_enabled",
release_custom_echarts_enabled: "release_custom_echarts_enabled", release_custom_echarts_enabled: "release_custom_echarts_enabled",
license_branding_enabled: "license_branding_enabled", license_branding_enabled: "license_branding_enabled",
ab_table_widget_activation_enabled: "ab_table_widget_activation_enabled",
ab_gif_signposting_enabled: "ab_gif_signposting_enabled", ab_gif_signposting_enabled: "ab_gif_signposting_enabled",
release_git_status_lite_enabled: "release_git_status_lite_enabled", release_git_status_lite_enabled: "release_git_status_lite_enabled",
license_sso_saml_enabled: "license_sso_saml_enabled", license_sso_saml_enabled: "license_sso_saml_enabled",
@ -44,7 +43,6 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
release_table_serverside_filtering_enabled: false, release_table_serverside_filtering_enabled: false,
release_custom_echarts_enabled: false, release_custom_echarts_enabled: false,
license_branding_enabled: false, license_branding_enabled: false,
ab_table_widget_activation_enabled: false,
ab_gif_signposting_enabled: false, ab_gif_signposting_enabled: false,
release_git_status_lite_enabled: false, release_git_status_lite_enabled: false,
license_sso_saml_enabled: false, license_sso_saml_enabled: false,

25
app/client/src/ce/sagas/ApplicationSagas.tsx
View File

@ -129,9 +129,6 @@ import {
keysOfNavigationSetting, keysOfNavigationSetting,
} from "constants/AppConstants"; } from "constants/AppConstants";
import { setAllEntityCollapsibleStates } from "actions/editorContextActions"; import { setAllEntityCollapsibleStates } from "actions/editorContextActions";
import { selectFeatureFlagCheck } from "@appsmith/selectors/featureFlagsSelectors";
import { FEATURE_FLAG } from "@appsmith/entities/FeatureFlag";
import { generateReactKey } from "utils/generators";
import { getCurrentEnvironmentId } from "@appsmith/selectors/environmentSelectors"; import { getCurrentEnvironmentId } from "@appsmith/selectors/environmentSelectors";
import type { DeletingMultipleApps } from "@appsmith/reducers/uiReducers/applicationsReducer"; import type { DeletingMultipleApps } from "@appsmith/reducers/uiReducers/applicationsReducer";
@ -649,28 +646,6 @@ export function* createApplicationSaga(
// ensures user receives the updates in the app just created // ensures user receives the updates in the app just created
yield put(reconnectAppLevelWebsocket()); yield put(reconnectAppLevelWebsocket());
yield put(reconnectPageLevelWebsocket()); yield put(reconnectPageLevelWebsocket());
const tableWidgetExperimentEnabled: boolean = yield select(
selectFeatureFlagCheck,
FEATURE_FLAG.ab_table_widget_activation_enabled,
);
if (tableWidgetExperimentEnabled) {
yield take(ReduxActionTypes.FETCH_WORKSPACE_SUCCESS);
yield put({
type: ReduxActionTypes.WIDGET_ADD_CHILD,
payload: {
widgetId: "0",
type: "TABLE_WIDGET_V2",
leftColumn: 15,
topRow: 6,
columns: 34,
rows: 28,
parentRowSpace: 10,
parentColumnSpace: 13.390625,
newWidgetId: generateReactKey(),
},
});
}
} }
} }
} catch (error) { } catch (error) {

23
app/client/src/sagas/OnboardingSagas.ts
View File

@ -87,8 +87,6 @@ import type { StepState } from "reducers/uiReducers/onBoardingReducer";
import { isUndefined } from "lodash"; import { isUndefined } from "lodash";
import { isAirgapped } from "@appsmith/utils/airgapHelpers"; import { isAirgapped } from "@appsmith/utils/airgapHelpers";
import { SIGNPOSTING_ANALYTICS_STEP_NAME } from "pages/Editor/FirstTimeUserOnboarding/constants"; import { SIGNPOSTING_ANALYTICS_STEP_NAME } from "pages/Editor/FirstTimeUserOnboarding/constants";
import { selectFeatureFlagCheck } from "@appsmith/selectors/featureFlagsSelectors";
import { FEATURE_FLAG } from "@appsmith/entities/FeatureFlag";
const GUIDED_TOUR_STORAGE_KEY = "GUIDED_TOUR_STORAGE_KEY"; const GUIDED_TOUR_STORAGE_KEY = "GUIDED_TOUR_STORAGE_KEY";
@ -460,27 +458,6 @@ function* firstTimeUserOnboardingInitSaga(
} }
yield put(setSignpostingOverlay(showOverlay)); yield put(setSignpostingOverlay(showOverlay));
const tableWidgetExperimentEnabled: boolean = yield select(
selectFeatureFlagCheck,
FEATURE_FLAG.ab_table_widget_activation_enabled,
);
if (tableWidgetExperimentEnabled) {
yield take(ReduxActionTypes.FETCH_WORKSPACE_SUCCESS);
yield put({
type: ReduxActionTypes.WIDGET_ADD_CHILD,
payload: {
widgetId: "0",
type: "TABLE_WIDGET_V2",
leftColumn: 15,
topRow: 6,
columns: 34,
rows: 28,
parentRowSpace: 10,
parentColumnSpace: 13.390625,
newWidgetId: generateReactKey(),
},
});
}
// Show the modal once the editor is loaded. The delay is to grab user attention back once the editor // Show the modal once the editor is loaded. The delay is to grab user attention back once the editor
yield delay(1000); yield delay(1000);
yield put({ yield put({