Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: remove deprecated feature flag for custom loading state in TableWidget (#38826)

Browse Source
This commit is contained in:
Rahul Barwal 2025-01-24 15:25:09 +05:30 committed by GitHub
parent efceb1e390
commit be2133eda8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/client/src/ce/entities/FeatureFlag.ts
View File

@ -36,8 +36,6 @@ export const FEATURE_FLAG = {
release_ide_animations_enabled: "release_ide_animations_enabled", release_ide_animations_enabled: "release_ide_animations_enabled",
release_ide_datasource_selector_enabled: release_ide_datasource_selector_enabled:
"release_ide_datasource_selector_enabled", "release_ide_datasource_selector_enabled",
release_table_custom_loading_state_enabled:
"release_table_custom_loading_state_enabled",
release_custom_widget_ai_builder: "release_custom_widget_ai_builder", release_custom_widget_ai_builder: "release_custom_widget_ai_builder",
ab_request_new_integration_enabled: "ab_request_new_integration_enabled", ab_request_new_integration_enabled: "ab_request_new_integration_enabled",
release_evaluation_scope_cache: "release_evaluation_scope_cache", release_evaluation_scope_cache: "release_evaluation_scope_cache",
@ -86,7 +84,6 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
release_git_persist_branch_enabled: false, release_git_persist_branch_enabled: false,
release_ide_animations_enabled: false, release_ide_animations_enabled: false,
release_ide_datasource_selector_enabled: false, release_ide_datasource_selector_enabled: false,
release_table_custom_loading_state_enabled: false,
release_custom_widget_ai_builder: false, release_custom_widget_ai_builder: false,
ab_request_new_integration_enabled: false, ab_request_new_integration_enabled: false,
release_evaluation_scope_cache: false, release_evaluation_scope_cache: false,

3
app/client/src/widgets/TableWidgetV2/constants.ts
View File

@ -244,8 +244,5 @@ export const DEFAULT_COLUMN_NAME = "Table Column";
export const ALLOW_TABLE_WIDGET_SERVER_SIDE_FILTERING = export const ALLOW_TABLE_WIDGET_SERVER_SIDE_FILTERING =
FEATURE_FLAG["release_table_serverside_filtering_enabled"]; FEATURE_FLAG["release_table_serverside_filtering_enabled"];
export const CUSTOM_LOADING_STATE_ENABLED =
FEATURE_FLAG["release_table_custom_loading_state_enabled"];
export const HTML_COLUMN_TYPE_ENABLED = export const HTML_COLUMN_TYPE_ENABLED =
FEATURE_FLAG["release_table_html_column_type_enabled"]; FEATURE_FLAG["release_table_html_column_type_enabled"];

6
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/contentConfig.ts
View File

@ -7,10 +7,7 @@ import { ValidationTypes } from "constants/WidgetValidation";
import { EvaluationSubstitutionType } from "entities/DataTree/dataTreeFactory"; import { EvaluationSubstitutionType } from "entities/DataTree/dataTreeFactory";
import { AutocompleteDataType } from "utils/autocomplete/AutocompleteDataType"; import { AutocompleteDataType } from "utils/autocomplete/AutocompleteDataType";
import type { TableWidgetProps } from "widgets/TableWidgetV2/constants"; import type { TableWidgetProps } from "widgets/TableWidgetV2/constants";
import { import { ALLOW_TABLE_WIDGET_SERVER_SIDE_FILTERING } from "../../constants";
ALLOW_TABLE_WIDGET_SERVER_SIDE_FILTERING,
CUSTOM_LOADING_STATE_ENABLED,
} from "../../constants";
import { InlineEditingSaveOptions } from "widgets/TableWidgetV2/constants"; import { InlineEditingSaveOptions } from "widgets/TableWidgetV2/constants";
import { composePropertyUpdateHook } from "widgets/WidgetUtils"; import { composePropertyUpdateHook } from "widgets/WidgetUtils";
import { import {
@ -513,7 +510,6 @@ export default [
isBindProperty: true, isBindProperty: true,
isTriggerProperty: false, isTriggerProperty: false,
validation: { type: ValidationTypes.BOOLEAN }, validation: { type: ValidationTypes.BOOLEAN },
hidden: () => !Widget.getFeatureFlag(CUSTOM_LOADING_STATE_ENABLED),
}, },
{ {
propertyName: "customIsLoadingValue", propertyName: "customIsLoadingValue",