Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: fix the WDS button widget click bug (#39874)

Browse Source 
/ok-to-test tags="@tag.Anvil"

The WDS Button widget was firing onClick twice. This was because we were
sending onClick + onPress to the widget. And it was firing both. We
don't need onClick prop.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Improved button click event handling for better integration with
verification features.
- Added styling changes to enhance text rendering within code blocks in
markdown content.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/14036976365>
> Commit: 5343c7e3c9d721a2d4b0d0282ecff514855823ab
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14036976365&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Mon, 24 Mar 2025 14:14:21 UTC
<!-- end of auto-generated comment: Cypress test results  -->
This commit is contained in:
Pawan Kumar 2025-03-25 10:18:20 +05:30 committed by GitHub
parent dbf2e2d37d
commit bc52865548
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/client/packages/design-system/widgets/src/components/Markdown/src/styles.module.css
View File

@ -108,6 +108,7 @@
pre { pre {
margin-top: var(--inner-spacing-4); margin-top: var(--inner-spacing-4);
margin-bottom: var(--inner-spacing-4); margin-bottom: var(--inner-spacing-4);
font-family: unset;
} }
blockquote { blockquote {

8
app/client/src/widgets/wds/WDSButtonWidget/component/index.tsx
View File

@ -17,9 +17,13 @@ export interface ButtonComponentProps extends ButtonProps {
} }
function ButtonComponent(props: ButtonComponentProps & UseRecaptchaProps) { function ButtonComponent(props: ButtonComponentProps & UseRecaptchaProps) {
const { icon, text, tooltip, ...rest } = props; const { icon, onClick: onClickProp, text, tooltip, ...rest } = props;
const { isFormValid, onReset } = useWDSZoneWidgetContext(); const { isFormValid, onReset } = useWDSZoneWidgetContext();
const { onClick, recpatcha } = useRecaptcha({ ...props, onReset }); const { onClick, recpatcha } = useRecaptcha({
...props,
onClick: onClickProp,
onReset,
});
const isDisabled = const isDisabled =
props.isDisabled || (props.disableOnInvalidForm && isFormValid === false); props.isDisabled || (props.disableOnInvalidForm && isFormValid === false);