diff --git a/app/client/src/pages/Editor/EditorName/NavigationMenuData.ts b/app/client/src/pages/Editor/EditorName/NavigationMenuData.ts index 38e1197b81..a4b66d82b0 100644 --- a/app/client/src/pages/Editor/EditorName/NavigationMenuData.ts +++ b/app/client/src/pages/Editor/EditorName/NavigationMenuData.ts @@ -6,8 +6,7 @@ import { ReduxActionTypes } from "@appsmith/constants/ReduxActionConstants"; import { APPLICATIONS_URL } from "constants/routes"; import type { MenuItemData } from "./NavigationMenuItem"; -import { MenuTypes } from "./NavigationMenuItem"; -import { useCallback } from "react"; +import { MenuTypes } from "./types"; import { getExportAppAPIRoute } from "@appsmith/constants/ApiConstants"; import { @@ -50,11 +49,11 @@ export const GetNavigationMenuData = ({ currentApplication?.userPermissions ?? [], PERMISSION_TYPE.MANAGE_APPLICATION, ); - const openExternalLink = useCallback((link: string) => { + const openExternalLink = (link: string) => { if (link) { window.open(link, "_blank"); } - }, []); + }; const exportAppAsJSON = () => { const id = `t--export-app-link`; diff --git a/app/client/src/pages/Editor/EditorName/NavigationMenuItem.tsx b/app/client/src/pages/Editor/EditorName/NavigationMenuItem.tsx index bf67000940..c50d7544ee 100644 --- a/app/client/src/pages/Editor/EditorName/NavigationMenuItem.tsx +++ b/app/client/src/pages/Editor/EditorName/NavigationMenuItem.tsx @@ -12,14 +12,7 @@ import type { noop } from "lodash"; import type { CommonComponentProps } from "design-system-old"; import AnalyticsUtil from "utils/AnalyticsUtil"; -import styled from "styled-components"; - -export enum MenuTypes { - MENU = "menu", - PARENT = "parent", - RECONFIRM = "re-confirm", - MENU_DIVIDER = "menu divider", -} +import { MenuTypes } from "./types"; export interface MenuItemData { text: string; @@ -35,12 +28,6 @@ export interface MenuItemData { style?: React.CSSProperties; } -const ReconfirmMenuItem = styled(MenuItem)` - .ads-v2-text { - color: var(--ads-v2-color-fg-error); - } -`; - type NavigationMenuItemProps = CommonComponentProps & { menuItemData: MenuItemData; setIsPopoverOpen: typeof noop; @@ -124,13 +111,13 @@ export function NavigationMenuItem({ ); case MenuTypes.RECONFIRM: return ( - handleReconfirmClick(e, menuItemData)} > {confirm.text} - + ); case MenuTypes.MENU_DIVIDER: return ; diff --git a/app/client/src/pages/Editor/EditorName/types.ts b/app/client/src/pages/Editor/EditorName/types.ts new file mode 100644 index 0000000000..02f6dde824 --- /dev/null +++ b/app/client/src/pages/Editor/EditorName/types.ts @@ -0,0 +1,6 @@ +export enum MenuTypes { + MENU = "menu", + PARENT = "parent", + RECONFIRM = "re-confirm", + MENU_DIVIDER = "menu divider", +}