chore: removed unnecessary injected services (#40965)
## Description ApplicationService and AnalyticService are not being used in OnLoadExecutablesUtilImpl.java and LayoutActionServiceCEImpl.java, this PR removes those dependencies. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/15706831590> > Commit: 1a97249544da874e53faffc255cea35adf9ba360 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=15706831590&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 17 Jun 2025 12:51:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed unused backend dependencies to streamline internal services. No changes to user-facing features or functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>
This commit is contained in:
parent
2dfe9d21ac
commit
b8af0d3020
|
|
@ -11,7 +11,6 @@ import com.appsmith.external.models.EntityReferenceType;
|
|||
import com.appsmith.external.models.Executable;
|
||||
import com.appsmith.external.models.Property;
|
||||
import com.appsmith.external.models.RunBehaviourEnum;
|
||||
import com.appsmith.server.applications.base.ApplicationService;
|
||||
import com.appsmith.server.domains.ExecutableDependencyEdge;
|
||||
import com.appsmith.server.domains.Layout;
|
||||
import com.appsmith.server.domains.NewPage;
|
||||
|
|
@ -23,7 +22,6 @@ import com.appsmith.server.helpers.CollectionUtils;
|
|||
import com.appsmith.server.helpers.ObservationHelperImpl;
|
||||
import com.appsmith.server.helpers.RunBehaviourAnalyticsUtils;
|
||||
import com.appsmith.server.onload.executables.ExecutableOnLoadService;
|
||||
import com.appsmith.server.services.AnalyticsService;
|
||||
import com.appsmith.server.services.AstService;
|
||||
import com.appsmith.server.services.FeatureFlagService;
|
||||
import com.fasterxml.jackson.core.type.TypeReference;
|
||||
|
|
@ -99,8 +97,6 @@ public class OnLoadExecutablesUtilCEImpl implements OnLoadExecutablesUtilCE {
|
|||
private final ObservationRegistry observationRegistry;
|
||||
private final ObservationHelperImpl observationHelper;
|
||||
private final FeatureFlagService featureFlagService;
|
||||
private final AnalyticsService analyticsService;
|
||||
private final ApplicationService applicationService;
|
||||
private final RunBehaviourAnalyticsUtils runBehaviourAnalyticsUtils;
|
||||
|
||||
/**
|
||||
|
|
|
|||
|
|
@ -1,11 +1,9 @@
|
|||
package com.appsmith.server.onload.internal;
|
||||
|
||||
import com.appsmith.server.applications.base.ApplicationService;
|
||||
import com.appsmith.server.domains.NewPage;
|
||||
import com.appsmith.server.helpers.ObservationHelperImpl;
|
||||
import com.appsmith.server.helpers.RunBehaviourAnalyticsUtils;
|
||||
import com.appsmith.server.onload.executables.ExecutableOnLoadService;
|
||||
import com.appsmith.server.services.AnalyticsService;
|
||||
import com.appsmith.server.services.AstService;
|
||||
import com.appsmith.server.services.FeatureFlagService;
|
||||
import com.fasterxml.jackson.databind.ObjectMapper;
|
||||
|
|
@ -24,8 +22,6 @@ public class OnLoadExecutablesUtilImpl extends OnLoadExecutablesUtilCEImpl imple
|
|||
ObservationRegistry observationRegistry,
|
||||
ObservationHelperImpl observationHelper,
|
||||
FeatureFlagService featureFlagService,
|
||||
AnalyticsService analyticsService,
|
||||
ApplicationService applicationService,
|
||||
RunBehaviourAnalyticsUtils runBehaviourAnalyticsUtils) {
|
||||
super(
|
||||
astService,
|
||||
|
|
@ -34,8 +30,6 @@ public class OnLoadExecutablesUtilImpl extends OnLoadExecutablesUtilCEImpl imple
|
|||
observationRegistry,
|
||||
observationHelper,
|
||||
featureFlagService,
|
||||
analyticsService,
|
||||
applicationService,
|
||||
runBehaviourAnalyticsUtils);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,6 +1,5 @@
|
|||
package com.appsmith.server.services;
|
||||
|
||||
import com.appsmith.server.applications.base.ApplicationService;
|
||||
import com.appsmith.server.datasources.base.DatasourceService;
|
||||
import com.appsmith.server.helpers.RunBehaviourAnalyticsUtils;
|
||||
import com.appsmith.server.layouts.UpdateLayoutService;
|
||||
|
|
@ -29,7 +28,6 @@ public class LayoutActionServiceImpl extends LayoutActionServiceCEImpl implement
|
|||
PagePermission pagePermission,
|
||||
ActionPermission actionPermission,
|
||||
ObservationRegistry observationRegistry,
|
||||
ApplicationService applicationService,
|
||||
RunBehaviourAnalyticsUtils runBehaviourAnalyticsUtils) {
|
||||
|
||||
super(
|
||||
|
|
@ -43,7 +41,6 @@ public class LayoutActionServiceImpl extends LayoutActionServiceCEImpl implement
|
|||
pagePermission,
|
||||
actionPermission,
|
||||
observationRegistry,
|
||||
applicationService,
|
||||
runBehaviourAnalyticsUtils);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -8,7 +8,6 @@ import com.appsmith.external.models.Datasource;
|
|||
import com.appsmith.external.models.PluginType;
|
||||
import com.appsmith.external.models.RunBehaviourEnum;
|
||||
import com.appsmith.server.acl.AclPermission;
|
||||
import com.appsmith.server.applications.base.ApplicationService;
|
||||
import com.appsmith.server.constants.FieldName;
|
||||
import com.appsmith.server.datasources.base.DatasourceService;
|
||||
import com.appsmith.server.domains.Layout;
|
||||
|
|
@ -68,7 +67,6 @@ public class LayoutActionServiceCEImpl implements LayoutActionServiceCE {
|
|||
private final PagePermission pagePermission;
|
||||
private final ActionPermission actionPermission;
|
||||
private final ObservationRegistry observationRegistry;
|
||||
private final ApplicationService applicationService;
|
||||
private final RunBehaviourAnalyticsUtils runBehaviourAnalyticsUtils;
|
||||
|
||||
/**
|
||||
|
|
|
|||
|
|
@ -6,11 +6,9 @@ import com.appsmith.external.models.ActionDTO;
|
|||
import com.appsmith.external.models.CreatorContextType;
|
||||
import com.appsmith.external.models.Executable;
|
||||
import com.appsmith.external.models.RunBehaviourEnum;
|
||||
import com.appsmith.server.applications.base.ApplicationService;
|
||||
import com.appsmith.server.helpers.ObservationHelperImpl;
|
||||
import com.appsmith.server.helpers.RunBehaviourAnalyticsUtils;
|
||||
import com.appsmith.server.onload.executables.ExecutableOnLoadService;
|
||||
import com.appsmith.server.services.AnalyticsService;
|
||||
import com.appsmith.server.services.AstService;
|
||||
import com.appsmith.server.services.FeatureFlagService;
|
||||
import com.fasterxml.jackson.databind.ObjectMapper;
|
||||
|
|
@ -62,12 +60,6 @@ public class OnLoadExecutablesUtilCEImplTest {
|
|||
|
||||
private OnLoadExecutablesUtilCEImpl onLoadExecutablesUtilCE;
|
||||
|
||||
@Mock
|
||||
private AnalyticsService analyticsService;
|
||||
|
||||
@Mock
|
||||
private ApplicationService applicationService;
|
||||
|
||||
@Mock
|
||||
private RunBehaviourAnalyticsUtils runBehaviourAnalyticsUtils;
|
||||
|
||||
|
|
@ -80,8 +72,6 @@ public class OnLoadExecutablesUtilCEImplTest {
|
|||
observationRegistry,
|
||||
observationHelper,
|
||||
featureFlagService,
|
||||
analyticsService,
|
||||
applicationService,
|
||||
runBehaviourAnalyticsUtils));
|
||||
|
||||
ObservationRegistry.ObservationConfig mockObservationConfig =
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user