diff --git a/app/client/cypress/e2e/Regression/ServerSide/ApiTests/CurlImportFlow_spec.js b/app/client/cypress/e2e/Regression/ServerSide/ApiTests/CurlImportFlow_spec.js index b0789a58ca..458f95272f 100644 --- a/app/client/cypress/e2e/Regression/ServerSide/ApiTests/CurlImportFlow_spec.js +++ b/app/client/cypress/e2e/Regression/ServerSide/ApiTests/CurlImportFlow_spec.js @@ -63,4 +63,14 @@ describe("Test curl import flow", function () { }); }); }); + + it("3. Bug:19214 Test curl import flow for request without any headers", function () { + cy.fixture("datasources").then((datasourceFormData) => { + _.dataSources.FillCurlNImport( + "curl -X GET " + datasourceFormData["echoApiUrl"], + ); + _.apiPage.AssertEmptyHeaderKeyValuePairsPresent(0); + _.apiPage.AssertEmptyHeaderKeyValuePairsPresent(1); + }); + }); }); diff --git a/app/client/cypress/support/Pages/ApiPage.ts b/app/client/cypress/support/Pages/ApiPage.ts index 366a2ab1d0..a5bee5319f 100644 --- a/app/client/cypress/support/Pages/ApiPage.ts +++ b/app/client/cypress/support/Pages/ApiPage.ts @@ -409,4 +409,9 @@ export class ApiPage { if (apiName) this.agHelper.RenameWithInPane(apiName); cy.get(this._resourceUrl).should("be.visible"); } + + AssertEmptyHeaderKeyValuePairsPresent(index: number) { + this.agHelper.AssertElementVisible(this._headerKey(index)); + this.agHelper.AssertElementVisible(this._headerValue(index)); + } } diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java index cf9e006ff4..bb936b9c94 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java @@ -427,9 +427,7 @@ public class CurlImporterServiceCEImpl extends BaseApiImporter implements CurlIm } } - if (!headers.isEmpty()) { - actionConfiguration.setHeaders(headers); - } + actionConfiguration.setHeaders(headers); if (!dataParts.isEmpty()) { if (MediaType.APPLICATION_FORM_URLENCODED_VALUE.equals(contentType)) {