Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix-Rename compact mode property in Table Widget to Row Height (#5496)

Browse Source 
* Change compact mode title to Row height in property pane configurations
This commit is contained in:
Vicky Bansal 2021-07-02 16:57:20 +05:30 committed by GitHub
parent fb9925cdc3
commit b6e205e5b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/DisplayWidgets/Table_spec.js
View File

@ -264,16 +264,16 @@ describe("Table Widget Functionality", function() {
const tabValue = tabData;
expect(tabValue).to.be.equal("Lindsay Ferguson");
cy.log("the value is" + tabValue);
cy.get(publish.compactMode).click();
cy.get(publish.compactOpt)
cy.get(publish.rowHeight).click();
cy.get(publish.rowHeightOpt)
.contains("Tall")
.click();
cy.scrollTabledataPublish("3", "3").then((tabData) => {
const tabValue = tabData;
expect(tabValue).to.be.equal("Byron Fields");
});
cy.get(publish.compactMode).click();
cy.get(publish.compactOpt)
cy.get(publish.rowHeight).click();
cy.get(publish.rowHeightOpt)
.contains("Short")
.click();
cy.readTabledataPublish("4", "3").then((tabData) => {

4
app/client/cypress/locators/publishWidgetspage.json
View File

@ -31,8 +31,8 @@
"inputValue": ".t--table-filter-value-input",
"canvas": ".canvas",
"removeFilter": ".t--table-filter-remove-btn",
"compactMode": ".t--table-compact-mode-toggle-btn",
"compactOpt": ".t--table-compact-mode-option",
"rowHeight": ".t--table-compact-mode-toggle-btn",
"rowHeightOpt": ".t--table-compact-mode-option",
"visibilityMode": ".t--table-column-visibility-toggle-btn",
"visibilityOpt": ".option-title",
"containerWidget": ".t--widget-containerwidget",

4
app/client/src/widgets/TableWidget/TablePropertyPaneConfig.ts
View File

@ -769,9 +769,9 @@ export default [
isTriggerProperty: false,
},
{
helpText: "Toggle visibility of the compact mode",
helpText: "Toggle visibility of the row height",
propertyName: "isVisibleCompactMode",
label: "Compact Mode",
label: "Row Height",
controlType: "SWITCH",
isBindProperty: false,
isTriggerProperty: false,