From 3f6b6da0e5a798c0a1164a48e35b3bf99c42a821 Mon Sep 17 00:00:00 2001 From: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Date: Wed, 5 Aug 2020 15:53:07 +0530 Subject: [PATCH 1/9] Use isExecutionSuccess for showing error response as status code string does not appear in query response (#226) --- app/client/src/api/ActionAPI.tsx | 1 + app/client/src/sagas/ActionExecutionSagas.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/client/src/api/ActionAPI.tsx b/app/client/src/api/ActionAPI.tsx index e8974f2668..b5b392326d 100644 --- a/app/client/src/api/ActionAPI.tsx +++ b/app/client/src/api/ActionAPI.tsx @@ -87,6 +87,7 @@ export interface ActionResponse { statusCode: string; duration: string; size: string; + isExecutionSuccess?: boolean; } export interface MoveActionRequest { diff --git a/app/client/src/sagas/ActionExecutionSagas.ts b/app/client/src/sagas/ActionExecutionSagas.ts index 7990b90d8f..278277230d 100644 --- a/app/client/src/sagas/ActionExecutionSagas.ts +++ b/app/client/src/sagas/ActionExecutionSagas.ts @@ -442,7 +442,7 @@ function* runActionSaga( type: ReduxActionTypes.RUN_ACTION_SUCCESS, payload: { [actionId]: payload }, }); - if (payload.statusCode[0] === "2") { + if (payload.isExecutionSuccess) { AppToaster.show({ message: "Action ran successfully", type: ToastType.SUCCESS, From c9616e5ba6056ba2c6f847ae3c958e9eef4ecc0e Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Wed, 5 Aug 2020 15:57:32 +0530 Subject: [PATCH 2/9] Update issue templates (#225) Updated Issue Template --- .github/ISSUE_TEMPLATE/---bug-report.md | 40 +++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/bug_report.md | 40 +++++++++++++++++++++++++ 2 files changed, 80 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/---bug-report.md create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md diff --git a/.github/ISSUE_TEMPLATE/---bug-report.md b/.github/ISSUE_TEMPLATE/---bug-report.md new file mode 100644 index 0000000000..d0a24e13bf --- /dev/null +++ b/.github/ISSUE_TEMPLATE/---bug-report.md @@ -0,0 +1,40 @@ +--- +name: "\U0001F41E Bug report" +about: Create a bug report to help us improve Appsmith +title: '' +labels: bug +assignees: Nikhil-Nandagopal + +--- + +## Description + +[What happened] + +### Steps to reproduce the behaviour: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +Good items to include here include: +- Console / network logs from your browser + +### What you expected to happen +A clear and concise description of what you expected to happen. + +### Screenshots +If applicable, add screenshots to help explain your problem. + +### Important Details + +How are you running appsmith? + +On-Premise w/ Docker, version x.y.z + +SaaS (appsmith.com) + + +Which browser / OS are you using? + - OS: [e.g.MacOSX] + - Browser [e.g. chrome, safari] diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000000..3759655d80 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,40 @@ +--- +name: Bug report +about: Create a bug report to help us improve Appsmith +title: '' +labels: bug +assignees: Nikhil-Nandagopal + +--- + +## Description + +[What happened] + +### Steps to reproduce the behaviour: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +Good items to include here include: +- Console / network logs from your browser + +### What you expected to happen +A clear and concise description of what you expected to happen. + +### Screenshots +If applicable, add screenshots to help explain your problem. + +### Important Details + +How are you running appsmith? + +On-Premise w/ Docker, version x.y.z + +SaaS (appsmith.com) + + +Which browser / OS are you using? + - OS: [e.g.MacOSX] + - Browser [e.g. chrome, safari] From 7ace4c66d9a3b8b821d6fc8c6cae4a1b500313c4 Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Wed, 5 Aug 2020 15:58:17 +0530 Subject: [PATCH 3/9] Update issue templates (#227) --- .github/ISSUE_TEMPLATE/----feature-request.md | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/----feature-request.md diff --git a/.github/ISSUE_TEMPLATE/----feature-request.md b/.github/ISSUE_TEMPLATE/----feature-request.md new file mode 100644 index 0000000000..8b8cc71e23 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/----feature-request.md @@ -0,0 +1,22 @@ +--- +name: "\U0001F6E0️ Feature request" +about: Suggest an idea for this project +title: "[FEATURE]" +labels: enhancement +assignees: Nikhil-Nandagopal + +--- + +## Summary + +One paragraph description of the feature. + +## Motivation + +Why should this be worked on? What problems or use cases does it solve or +improve? + +## Additional Context + +Any other context or screenshots or API request payload/responses that you +pertain to the feature. From d7c3370b242fcdb137329b11f3ef22a62ec1619d Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Wed, 5 Aug 2020 16:00:37 +0530 Subject: [PATCH 4/9] Update issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 40 ---------------------------- 1 file changed, 40 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/bug_report.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md deleted file mode 100644 index 3759655d80..0000000000 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ /dev/null @@ -1,40 +0,0 @@ ---- -name: Bug report -about: Create a bug report to help us improve Appsmith -title: '' -labels: bug -assignees: Nikhil-Nandagopal - ---- - -## Description - -[What happened] - -### Steps to reproduce the behaviour: -1. Go to '...' -2. Click on '....' -3. Scroll down to '....' -4. See error - -Good items to include here include: -- Console / network logs from your browser - -### What you expected to happen -A clear and concise description of what you expected to happen. - -### Screenshots -If applicable, add screenshots to help explain your problem. - -### Important Details - -How are you running appsmith? - -On-Premise w/ Docker, version x.y.z - -SaaS (appsmith.com) - - -Which browser / OS are you using? - - OS: [e.g.MacOSX] - - Browser [e.g. chrome, safari] From ae49aa595186481333fc0c637309260a9bb63793 Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Wed, 5 Aug 2020 16:05:34 +0530 Subject: [PATCH 5/9] Create config.yml --- .github/ISSUE_TEMPLATE/config.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/config.yml diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 0000000000..3e75c40bfe --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,5 @@ +blank_issues_enabled: false +contact_links: + - name: 🤔 Questions and Help + url: https://discord.com/invite/rBTTVJp + about: This issue tracker is not for support questions. Please refer to the Appsmith community's help and discussion forums. From c090108a895a951906c971af6d4b40a6c1768d41 Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Wed, 5 Aug 2020 16:13:42 +0530 Subject: [PATCH 6/9] Update issue templates --- .github/ISSUE_TEMPLATE/---bug-report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/---bug-report.md b/.github/ISSUE_TEMPLATE/---bug-report.md index d0a24e13bf..57b2e24166 100644 --- a/.github/ISSUE_TEMPLATE/---bug-report.md +++ b/.github/ISSUE_TEMPLATE/---bug-report.md @@ -1,7 +1,7 @@ --- name: "\U0001F41E Bug report" about: Create a bug report to help us improve Appsmith -title: '' +title: "[BUG]" labels: bug assignees: Nikhil-Nandagopal From d2290a2314b6d025b17cc5de93047ba6e683fad4 Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Wed, 5 Aug 2020 16:14:47 +0530 Subject: [PATCH 7/9] Update issue templates --- .github/ISSUE_TEMPLATE/---bug-report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/---bug-report.md b/.github/ISSUE_TEMPLATE/---bug-report.md index 57b2e24166..f3ed5ac7ef 100644 --- a/.github/ISSUE_TEMPLATE/---bug-report.md +++ b/.github/ISSUE_TEMPLATE/---bug-report.md @@ -1,5 +1,5 @@ --- -name: "\U0001F41E Bug report" +name: "\U0001F41B Bug report" about: Create a bug report to help us improve Appsmith title: "[BUG]" labels: bug From a2c6d4938dbe4c14980722738b42dff6a5a34856 Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Wed, 5 Aug 2020 16:23:05 +0530 Subject: [PATCH 8/9] Update config.yml --- .github/ISSUE_TEMPLATE/config.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 3e75c40bfe..0d881dee31 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -2,4 +2,7 @@ blank_issues_enabled: false contact_links: - name: 🤔 Questions and Help url: https://discord.com/invite/rBTTVJp - about: This issue tracker is not for support questions. Please refer to the Appsmith community's help and discussion forums. + about: Reach out to us on discord or our github discussions page. + - name: 📞 Dedicated Support + url: https://mail.google.com/mail/u/0/?view=cm&fs=1&to=support@appsmith.com&tf=1 + about: Write to us if you'd like dedicated support using appsmith From c4ae61a0707405aee139a51ed8758d409bbd6a38 Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Wed, 5 Aug 2020 16:28:25 +0530 Subject: [PATCH 9/9] Update issue templates --- .github/ISSUE_TEMPLATE/----feature-request.md | 2 +- .github/ISSUE_TEMPLATE/---bug-report.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/----feature-request.md b/.github/ISSUE_TEMPLATE/----feature-request.md index 8b8cc71e23..fc7c635c9d 100644 --- a/.github/ISSUE_TEMPLATE/----feature-request.md +++ b/.github/ISSUE_TEMPLATE/----feature-request.md @@ -1,6 +1,6 @@ --- name: "\U0001F6E0️ Feature request" -about: Suggest an idea for this project +about: Suggest an idea to improve appsmith title: "[FEATURE]" labels: enhancement assignees: Nikhil-Nandagopal diff --git a/.github/ISSUE_TEMPLATE/---bug-report.md b/.github/ISSUE_TEMPLATE/---bug-report.md index f3ed5ac7ef..e84fbaca6a 100644 --- a/.github/ISSUE_TEMPLATE/---bug-report.md +++ b/.github/ISSUE_TEMPLATE/---bug-report.md @@ -1,6 +1,6 @@ --- name: "\U0001F41B Bug report" -about: Create a bug report to help us improve Appsmith +about: Create a bug report to help us improve appsmith title: "[BUG]" labels: bug assignees: Nikhil-Nandagopal