Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: changed cap default to fix ux issue on js toggle (#10424)

Browse Source 
* fix: changed cap default to fix ux issue on js toggle

* fix: hard check on capSide hide

* fix: always show capSide if dynamic capType

* docs: label, help text update

* fix: remove hidden condition
This commit is contained in:
Bhavin K 2022-01-25 19:24:36 +05:30 committed by GitHub
parent cd02572374
commit b52ec44966
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/client/src/widgets/DividerWidget/widget/index.tsx
View File

@ -149,15 +149,15 @@ class DividerWidget extends BaseWidget<DividerWidgetProps, WidgetState> {
params: { params: {
allowedValues: ["nc", "arrow", "dot"], allowedValues: ["nc", "arrow", "dot"],
required: true, required: true,
default: "arrow", default: "nc",
}, },
}, },
}, },
{ {
helpText: helpText:
"Controls hide/show divider cap on start or end of divider", "Changes the position of the cap if a valid cap is selected.",
propertyName: "capSide", propertyName: "capSide",
label: "", label: "Cap Position",
controlType: "ICON_TABS", controlType: "ICON_TABS",
options: [ options: [
{ {
@ -177,8 +177,6 @@ class DividerWidget extends BaseWidget<DividerWidgetProps, WidgetState> {
defaultValue: "0", defaultValue: "0",
isBindProperty: false, isBindProperty: false,
isTriggerProperty: false, isTriggerProperty: false,
hidden: (props: DividerWidgetProps) => props.capType === "nc",
dependencies: ["capType"],
}, },
], ],
}, },