Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Fix container-internal communication when using IPv6 (#20981)

Browse Source 
When services within the fat container try to communicate with each
other, like backend to RTS etc., if they use the loopback address of
IPv4, `127.0.0.1`, it works. But if they use the loopback address of
IPv6, `::1`, it fails because the NGINX inside the fat container isn't
set to bind to IPv6.

This PR fixes this.

In EE, we attempt to make connections to Keycloak without setting the
hostname on the `WebClient`. This picks up the hostname of `::1` on
systems with IPv6 as default, and so the communication between backend
and Keycloak fails.

This is affecting users on ECS Fargate, for example.
This commit is contained in:
Shrikant Sharat Kandula 2023-02-27 19:51:54 +05:30 committed by GitHub
parent 3f0c8dccdf
commit b3dbd85dbe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/client/docker/templates/nginx-app-http.conf.template
View File

@ -1,5 +1,6 @@
server {
listen 80;
listen [::]:80;
server_name $APPSMITH_DOMAIN;
client_max_body_size 150m;

2
app/client/docker/templates/nginx-app-https.conf.template
View File

@ -1,5 +1,6 @@
server {
listen 80;
listen [::]:80;
server_name $APPSMITH_DOMAIN;
return 301 https://$host$request_uri;
@ -7,6 +8,7 @@ server {
server {
listen 443 ssl http2;
listen [::]:443 ssl http2;
server_name _;
ssl_certificate ${APPSMITH_SSL_CERT_PATH};

2
app/client/docker/templates/nginx-app.conf.template
View File

@ -1,5 +1,6 @@
server {
listen 80;
listen [::]:80;
server_name dev.appsmith.com;
return 301 https://$host$request_uri;
@ -7,6 +8,7 @@ server {
server {
listen 443 ssl http2;
listen [::]:443 ssl http2;
server_name dev.appsmith.com;
client_max_body_size 150m;

3
app/client/start-https.sh
View File

@ -233,6 +233,7 @@ http {
$(if [[ $use_https == 1 ]]; then echo "
server {
listen $http_listen_port default_server;
listen [::]:$http_listen_port default_server;
server_name $domain;
return 301 https://\$host$(if [[ $https_listen_port != 443 ]]; then echo ":$https_listen_port"; fi)\$request_uri;
}
@ -241,11 +242,13 @@ $(if [[ $use_https == 1 ]]; then echo "
server {
$(if [[ $use_https == 1 ]]; then echo "
listen $https_listen_port ssl http2 default_server;
listen [::]:$https_listen_port ssl http2 default_server;
server_name $domain;
ssl_certificate '$cert_file';
ssl_certificate_key '$key_file';
"; else echo "
listen $http_listen_port default_server;
listen [::]:$http_listen_port default_server;
server_name _;
"; fi)

1
deploy/docker/templates/nginx/nginx-app-http.conf.template.sh
View File

@ -24,6 +24,7 @@ access_log /dev/stdout;
server {
listen ${PORT:-80} default_server;
listen [::]:${PORT:-80} default_server;
server_name $CUSTOM_DOMAIN;
client_max_body_size 150m;

2
deploy/docker/templates/nginx/nginx-app-https.conf.template.sh
View File

@ -30,6 +30,7 @@ access_log /dev/stdout;
server {
listen 80;
listen [::]:80;
server_name $CUSTOM_DOMAIN;
return 301 https://\$host\$request_uri;
@ -37,6 +38,7 @@ server {
server {
listen 443 ssl http2;
listen [::]:443 ssl http2;
server_name _;
ssl_certificate $SSL_CERT_PATH;