From b24b66f4508d61e5f69cf033dcc4a90bc886b0df Mon Sep 17 00:00:00 2001 From: Rajat Agrawal Date: Tue, 12 Nov 2024 11:07:20 +0530 Subject: [PATCH] chore: Add span for measuring performance of consolidated api (#37328) This PR adds spans for fetching consolidated api from client perspective ## Summary by CodeRabbit - **New Features** - Enhanced API call functionality with improved error handling and response validation. - Added tracing for better observability during API interactions. - **Bug Fixes** - Refined error handling for specific scenarios, including unauthorized access. - **Documentation** - Updated function signatures for better clarity on API response handling. --- app/client/src/sagas/InitSagas.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/client/src/sagas/InitSagas.ts b/app/client/src/sagas/InitSagas.ts index e7655dc20f..05f6030385 100644 --- a/app/client/src/sagas/InitSagas.ts +++ b/app/client/src/sagas/InitSagas.ts @@ -240,11 +240,14 @@ export function* getInitResponses({ shouldInitialiseUserDetails, ); + const rootSpan = startRootSpan("fetch-consolidated-api"); const initConsolidatedApiResponse: ApiResponse = yield mode === APP_MODE.EDIT ? ConsolidatedPageLoadApi.getConsolidatedPageLoadDataEdit(params) : ConsolidatedPageLoadApi.getConsolidatedPageLoadDataView(params); + endSpan(rootSpan); + const isValidResponse: boolean = yield validateResponse( initConsolidatedApiResponse, );