Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Add null check for evaluated value in Chart Data Control (#1675)

Browse Source 
Fixes: #1672, #1666
This commit is contained in:
Hetu Nandu 2020-11-11 17:28:26 +05:30 committed by GitHub
parent 3a84af82ed
commit b1c8008c3d
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/client/src/components/propertyControls/ChartDataControl.tsx
View File

@ -167,6 +167,13 @@ class ChartDataControl extends BaseControl<ControlProps> {
return validations; return validations;
}; };
getEvaluatedValue = () => {
if (Array.isArray(this.props.evaluatedValue)) {
return this.props.evaluatedValue;
}
return [];
};
componentDidMount() { componentDidMount() {
this.migrateChartData(this.props.propertyValue); this.migrateChartData(this.props.propertyValue);
} }
@ -209,6 +216,9 @@ class ChartDataControl extends BaseControl<ControlProps> {
isValid, isValid,
chartData.length, chartData.length,
); );
const evaluatedValue = this.getEvaluatedValue();
return ( return (
<React.Fragment> <React.Fragment>
{chartData.map((data, index) => { {chartData.map((data, index) => {
@ -222,7 +232,7 @@ class ChartDataControl extends BaseControl<ControlProps> {
updateOption={this.updateOption} updateOption={this.updateOption}
isValid={validations[index].isValid} isValid={validations[index].isValid}
validationMessage={validations[index].validationMessage} validationMessage={validations[index].validationMessage}
evaluated={this.props.evaluatedValue[index]} evaluated={evaluatedValue[index]}
/> />
); );
})} })}