Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix NPE when accessing services before OPA is ready.

Browse Source
This commit is contained in:
Shrikant Kandula 2020-04-22 08:41:40 +05:30
parent 1a19a9b698
commit a8842e962b
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/server/appsmith-server/src/main/java/com/appsmith/server/acl/OpaResponse.java
View File

@ -1,12 +1,14 @@
package com.appsmith.server.acl; package com.appsmith.server.acl;
import lombok.Getter;
import lombok.Setter; import lombok.Setter;
import lombok.ToString; import lombok.ToString;
@Getter
@Setter @Setter
@ToString @ToString
public class OpaResponse { public class OpaResponse {
Boolean result; Boolean result;
public boolean isSuccessful() {
return Boolean.TRUE.equals(result);
}
} }

2
app/server/appsmith-server/src/main/java/com/appsmith/server/filters/AclFilter.java
View File

@ -71,7 +71,7 @@ public class AclFilter implements WebFilter {
return acl; return acl;
}) })
.flatMap(acl -> { .flatMap(acl -> {
if (acl != null && acl.getResult()) { if (acl != null && acl.isSuccessful()) {
// Acl returned true. Continue with the filter chain // Acl returned true. Continue with the filter chain
return chain.filter(exchange); return chain.filter(exchange);
} }