fix: asserting getApplicationsOfWorkspace call before clicking skip (#32311)
## Description Asserting getApplicationsOfWorkspace call before clicking `Skip this step, I`ll do it later` button to move to the application screen. Tldr: Earlier was failing because the applications in the workspace were not available (or the network call was already in progress) and when the button was clicked because of the application condition, it was not redirecting to the application screen. Now we wait for the applications network call to finish before clicking on the Skip button. Fixes #32310 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8522236782> > Commit: `e94458e2051502af269082e46c5811717877b32b` > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8522236782&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/IDE/IDE_Add_Pane_Interactions_spec.ts </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Enhanced user interaction on the homepage for improved usability. - Streamlined the process for creating superuser accounts. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
parent
0959160554
commit
a40e16adb3
|
|
@ -463,6 +463,8 @@ export class HomePage {
|
|||
}
|
||||
});
|
||||
|
||||
this.assertHelper.AssertNetworkStatus("@getApplicationsOfWorkspace");
|
||||
|
||||
if (skipToApplication) {
|
||||
this.agHelper.WaitUntilEleAppear(
|
||||
this.onboarding.locators.skipStartFromData,
|
||||
|
|
|
|||
|
|
@ -1327,6 +1327,7 @@ Cypress.Commands.add("createSuperUser", () => {
|
|||
cy.wait(2000);
|
||||
|
||||
if (CURRENT_REPO === REPO.CE) {
|
||||
assertHelper.AssertNetworkStatus("@getApplicationsOfWorkspace");
|
||||
agHelper.WaitUntilEleAppear(onboarding.locators.skipStartFromData);
|
||||
agHelper.GetNClick(onboarding.locators.skipStartFromData);
|
||||
cy.get("#loading").should("not.exist");
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user