fix: Added height to new query button menu (#29729)
## Description This PR adds a fixed height to the new query button in datasource config page. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29609 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated the action button to have a conditional height based on the number of pages for improved layout consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
parent
078ef8a538
commit
a185256f6a
|
|
@ -101,7 +101,6 @@ function NewActionButton(props: NewActionButtonProps) {
|
|||
},
|
||||
[pages, createQueryAction, disabled, isLoading],
|
||||
);
|
||||
|
||||
return (
|
||||
<Menu onOpenChange={handleOnInteraction} open={isPageSelectionOpen}>
|
||||
<MenuTrigger disabled={disabled}>
|
||||
|
|
@ -123,6 +122,7 @@ function NewActionButton(props: NewActionButtonProps) {
|
|||
<MenuContent
|
||||
align={"end"}
|
||||
data-testId={"t--page-selection"}
|
||||
height={pages.length <= 4 ? "fit-content" : "186px"}
|
||||
side={"bottom"}
|
||||
>
|
||||
<Text className="pl-2" kind="heading-xs">{`Create a ${
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user