chore: Return failure results (#36233)

## Description

**Problem:** When running Cypress tests multiple times with the
cypress-repeat-pro --force option, we only see success messages. This is
because the `--force` option may override or mask failures, leading to
misleading results.

**Solution:** To address this, we have added a step to check for
specific failure indicators in the test summary file. If the summary
indicates that there were any failed tests (i.e., `Total Failed: 0` is
not present), the GitHub Action step will fail. This ensures that
failures are properly highlighted and reported in the PR comments.


Fixes #`36232`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10806403675>
> Commit: 3a04b01650a4f92967d6b489eead5d61e48cb89a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10806403675&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 11 Sep 2024 07:01:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced CI workflow to ensure GitHub Action fails if Cypress tests do
not pass, improving reliability.
  
- **Bug Fixes**
- Implemented a conditional check for test failures, providing clearer
feedback on test outcomes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Sagar Khalasi 2024-09-11 15:08:12 +05:30 committed by GitHub
parent 89154c56cd
commit a182e7409d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -349,7 +349,12 @@ jobs:
npx cypress-repeat-pro run -n ${{ inputs.run_count }} --force \
--spec ${{ env.specs_to_run }} \
--config-file "cypress_ci_custom.config.ts"
cat cy-repeat-summary.txt
cat cy-repeat-summary.txt
# Check if "Total Failed: 0" is present
if ! grep -q "Total Failed: 0" cy-repeat-summary.txt; then
echo "Tests failed, failing the GitHub Action."
exit 1 # Fails the step if tests failed
fi
- name: Trim number of cypress log files
if: failure()