Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Corrected action execution analytics event (#18783)

Browse Source
This commit is contained in:
Vishnu Gp 2022-12-08 21:05:34 +05:30 committed by GitHub
parent 3b98c8f7fe
commit a1702d9b2e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/AnalyticsServiceCEImpl.java
View File

@ -4,6 +4,7 @@ import com.appsmith.external.constants.AnalyticsEvents;
import com.appsmith.external.models.BaseDomain; import com.appsmith.external.models.BaseDomain;
import com.appsmith.server.configurations.CommonConfig; import com.appsmith.server.configurations.CommonConfig;
import com.appsmith.server.constants.FieldName; import com.appsmith.server.constants.FieldName;
import com.appsmith.server.domains.NewAction;
import com.appsmith.server.domains.NewPage; import com.appsmith.server.domains.NewPage;
import com.appsmith.server.domains.User; import com.appsmith.server.domains.User;
import com.appsmith.server.domains.UserData; import com.appsmith.server.domains.UserData;
@ -197,10 +198,11 @@ public class AnalyticsServiceCEImpl implements AnalyticsServiceCE {
return userMono return userMono
.map(user -> { .map(user -> {
// In case the user is anonymous, don't raise an event, unless it's a signup, logout or page view event. // In case the user is anonymous, don't raise an event, unless it's a signup, logout, page view or action execution event.
boolean isEventUserSignUpOrLogout = object instanceof User && (event == AnalyticsEvents.CREATE || event == AnalyticsEvents.LOGOUT); boolean isEventUserSignUpOrLogout = object instanceof User && (event == AnalyticsEvents.CREATE || event == AnalyticsEvents.LOGOUT);
boolean isEventPageView = object instanceof NewPage && event == AnalyticsEvents.VIEW; boolean isEventPageView = object instanceof NewPage && event == AnalyticsEvents.VIEW;
boolean isAvoidLoggingEvent = user.isAnonymous() && !(isEventUserSignUpOrLogout || isEventPageView); boolean isEventActionExecution = object instanceof NewAction && event == AnalyticsEvents.EXECUTE_ACTION;
boolean isAvoidLoggingEvent = user.isAnonymous() && !(isEventUserSignUpOrLogout || isEventPageView || isEventActionExecution);
if (isAvoidLoggingEvent) { if (isAvoidLoggingEvent) {
return object; return object;
} }