From 9f2c32b9dee72c2b68ea82d27873b1e09ef58d7f Mon Sep 17 00:00:00 2001 From: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Date: Fri, 8 Oct 2021 13:22:08 +0530 Subject: [PATCH] fix: onboarding table widget is blank after adding binding (#8285) --- .../Onboarding/Onboarding_spec.js | 5 +++++ app/client/cypress/support/commands.js | 5 +++++ app/client/src/sagas/OnboardingSagas.ts | 22 +++++++------------ 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/Onboarding_spec.js b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/Onboarding_spec.js index f8c64517e5..4a2b970cf8 100644 --- a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/Onboarding_spec.js +++ b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/Onboarding_spec.js @@ -66,6 +66,11 @@ describe("Onboarding", function() { .should("be.visible") .click(); + // Check if table is showing any data + cy.getTableDataSelector("0", "0").then((selector) => { + cy.get(selector).should("be.visible"); + }); + // wait for animation duration // eslint-disable-next-line cypress/no-unnecessary-waiting cy.wait(1000); diff --git a/app/client/cypress/support/commands.js b/app/client/cypress/support/commands.js index b9afe58252..7fe550ada3 100644 --- a/app/client/cypress/support/commands.js +++ b/app/client/cypress/support/commands.js @@ -2739,6 +2739,11 @@ Cypress.Commands.add("ExportVerify", (togglecss, name) => { cy.togglebarDisable(togglecss); }); +Cypress.Commands.add("getTableDataSelector", (rowNum, colNum) => { + const selector = `.t--widget-tablewidget .tbody .td[data-rowindex=${rowNum}][data-colindex=${colNum}] div`; + return selector; +}); + Cypress.Commands.add("readTabledataPublish", (rowNum, colNum) => { // const selector = `.t--widget-tablewidget .e-gridcontent.e-lib.e-droppable td[index=${rowNum}][aria-colindex=${colNum}]`; const selector = `.t--widget-tablewidget .tbody .td[data-rowindex=${rowNum}][data-colindex=${colNum}] div`; diff --git a/app/client/src/sagas/OnboardingSagas.ts b/app/client/src/sagas/OnboardingSagas.ts index 940b669cd3..0ddb69bf97 100644 --- a/app/client/src/sagas/OnboardingSagas.ts +++ b/app/client/src/sagas/OnboardingSagas.ts @@ -175,8 +175,14 @@ function* listenForWidgetAdditions() { widgetName: "Standup_Table", tableData: [], columnSizeMap: { - avatar: 20, - name: 30, + avatar: 80, + name: 120, + }, + columnTypeMap: { + avatar: { + type: "image", + format: "", + }, }, migrated: false, ...getStandupTableDimensions(), @@ -334,18 +340,6 @@ function* listenForSuccessfulBinding() { errors.length === 0; if (bindSuccessful) { - yield put( - batchUpdateWidgetProperty(selectedWidget.widgetId, { - modify: { - columnTypeMap: { - avatar: { - type: "image", - format: "", - }, - }, - }, - }), - ); AnalyticsUtil.logEvent("ONBOARDING_SUCCESSFUL_BINDING"); yield put(setCurrentStep(OnboardingStep.ADD_INPUT_WIDGET));