Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

ci: Do case-insensitive tag matches (#34481)

Browse Source 
Specifying the `/test` command like this:

```
/test IDE
```

Doesn't pick up the `@tag.IDE` tag, but using `/test ide` does. This is
because of incorrect case-matching logic. This PR fixes this.





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
  - Enhanced case-insensitivity for tag matching to reduce errors.
- Improved error messaging for unmatched tags to provide clearer
feedback.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Shrikant Sharat Kandula 2024-06-26 13:17:42 +05:30 committed by GitHub
parent 854d3f03da
commit 9c16e4f365
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.github/workflows/scripts/test-tag-parser.js vendored
View File

@ -18,9 +18,10 @@ function parseTags({core, context}) {
for (const [rawTag] of config.matchAll(/\w+/g)) {
console.log("Given: '" + rawTag + "'");
const rawTagLowerAndPrefixed = "@tag." + rawTag.toLowerCase();
// See if there is exact case-insensitive match.
const exactTagMatch = allTags.find(t => t.toLowerCase() === "@tag." + rawTag);
const exactTagMatch = allTags.find(t => t.toLowerCase() === rawTagLowerAndPrefixed);
if (exactTagMatch) {
console.log("\tMatch found:", exactTagMatch);
concreteTags.push(exactTagMatch);
@ -28,7 +29,7 @@ function parseTags({core, context}) {
}
// See if there is a singular/plural match (very rudimentary language skills).
const countedMatch = allTags.find(t => t.toLowerCase().replace(/s$/, "") === "@tag." + rawTag.replace(/s$/, ""));
const countedMatch = allTags.find(t => t.toLowerCase().replace(/s$/, "") === rawTagLowerAndPrefixed.replace(/s$/, ""));
if (countedMatch) {
console.log("\tMatch found:", countedMatch);
concreteTags.push(countedMatch);
@ -38,7 +39,7 @@ function parseTags({core, context}) {
// More smart matchers?
// No match, fail.
core.setFailed("\tNo match found for tag:", rawTag);
core.setFailed("\tNo match found for tag: " + rawTag);
// We still process the rest, so we report all invalid tags in the input in a single run.
}