fix: use newer editableText component (#24342)

## Description

1. Removes red background on error (fixes
https://github.com/appsmithorg/appsmith/issues/24098)
2. Changes saving state icon to use new standard `loader` icon (fixes
https://github.com/appsmithorg/appsmith/issues/24112)


#### Media


https://github.com/appsmithorg/appsmith/assets/13763558/d5fc8b4d-f3cd-4b9d-a0d7-54c9aa9921c6

>
#### Type of change

- Bug fix (non-breaking change which fixes an issue)
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
Tanvi Bhakta 2023-06-14 10:02:42 +05:30 committed by GitHub
parent 7b893ef1bf
commit 9b770d860a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions

View File

@ -92,7 +92,7 @@
"dayjs": "^1.10.6",
"deep-diff": "^1.0.2",
"design-system": "npm:@appsmithorg/design-system@2.1.12",
"design-system-old": "npm:@appsmithorg/design-system-old@1.1.8",
"design-system-old": "npm:@appsmithorg/design-system-old@1.1.9",
"downloadjs": "^1.4.7",
"fast-deep-equal": "^3.1.3",
"fast-xml-parser": "^3.17.5",

View File

@ -9639,7 +9639,7 @@ __metadata:
dayjs: ^1.10.6
deep-diff: ^1.0.2
design-system: "npm:@appsmithorg/design-system@2.1.12"
design-system-old: "npm:@appsmithorg/design-system-old@1.1.8"
design-system-old: "npm:@appsmithorg/design-system-old@1.1.9"
diff: ^5.0.0
dotenv: ^8.1.0
downloadjs: ^1.4.7
@ -13649,9 +13649,9 @@ __metadata:
languageName: node
linkType: hard
"design-system-old@npm:@appsmithorg/design-system-old@1.1.8":
version: 1.1.8
resolution: "@appsmithorg/design-system-old@npm:1.1.8"
"design-system-old@npm:@appsmithorg/design-system-old@1.1.9":
version: 1.1.9
resolution: "@appsmithorg/design-system-old@npm:1.1.9"
dependencies:
emoji-mart: 3.0.1
peerDependencies:
@ -13671,7 +13671,7 @@ __metadata:
remixicon-react: ^1.0.0
styled-components: 5.3.6
tinycolor2: ^1.4.2
checksum: 962a596585337ad08db8141a3ad37bf8e7c0819bdea20bcc4fecc63135c454d67a09261af99d323a0adaec6834128bda1e37f4d18b3607acd95d042fc78319ce
checksum: c577f912c19f5990f62abb5c3c82dd084bc9baf8b8acd3f095ea9bf3ea578c97a335e41097c72b4e93e98e791246f6ab32a9a8f3b795497c658269eb4162c5f9
languageName: node
linkType: hard