From 99466e197d616e0aa6575e7ae0bdc16dfe6f09f9 Mon Sep 17 00:00:00 2001 From: Manish Kumar <107841575+sondermanish@users.noreply.github.com> Date: Wed, 17 May 2023 09:45:00 +0530 Subject: [PATCH] chore: added application name in JDBC url for connection URI (#23074) ## Description This PR includes changes for: - Snowflake - Redshift > TL;DR: Modifying connection string to reduce auxiliary connection to datasources in order to required properties. Fixes #22659 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? This has been tested - [x] Manual - [ ] Jest - [ ] Cypress > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --- .../src/main/java/com/external/plugins/SnowflakePlugin.java | 1 + 1 file changed, 1 insertion(+) diff --git a/app/server/appsmith-plugins/snowflakePlugin/src/main/java/com/external/plugins/SnowflakePlugin.java b/app/server/appsmith-plugins/snowflakePlugin/src/main/java/com/external/plugins/SnowflakePlugin.java index e41e81c869..e2d53a7fcd 100644 --- a/app/server/appsmith-plugins/snowflakePlugin/src/main/java/com/external/plugins/SnowflakePlugin.java +++ b/app/server/appsmith-plugins/snowflakePlugin/src/main/java/com/external/plugins/SnowflakePlugin.java @@ -152,6 +152,7 @@ public class SnowflakePlugin extends BasePlugin { properties.setProperty("role", String.valueOf(datasourceConfiguration.getProperties().get(3).getValue())); /* Ref: https://github.com/appsmithorg/appsmith/issues/19784 */ properties.setProperty("jdbc_query_result_format", "json"); + properties.setProperty("APPLICATION", "APPSMITH_JDBC_DRIVER"); return Mono .fromCallable(() -> {