Revert "Hotfix for logging and debugging redux updates (#6728)"
This reverts commit 4b5ca10e0d.
This commit is contained in:
parent
e76d8c2c15
commit
9941c253f7
|
|
@ -3,7 +3,6 @@ import { applyChange, Diff } from "deep-diff";
|
||||||
import { DataTree } from "entities/DataTree/dataTreeFactory";
|
import { DataTree } from "entities/DataTree/dataTreeFactory";
|
||||||
import { createImmerReducer } from "utils/AppsmithUtils";
|
import { createImmerReducer } from "utils/AppsmithUtils";
|
||||||
import * as Sentry from "@sentry/react";
|
import * as Sentry from "@sentry/react";
|
||||||
import log from "loglevel";
|
|
||||||
|
|
||||||
export type EvaluatedTreeState = DataTree;
|
export type EvaluatedTreeState = DataTree;
|
||||||
|
|
||||||
|
|
@ -30,7 +29,6 @@ const evaluatedTreeReducer = createImmerReducer(initialState, {
|
||||||
try {
|
try {
|
||||||
applyChange(state, undefined, update);
|
applyChange(state, undefined, update);
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
log.error(e);
|
|
||||||
Sentry.captureException(e, {
|
Sentry.captureException(e, {
|
||||||
extra: {
|
extra: {
|
||||||
update,
|
update,
|
||||||
|
|
|
||||||
|
|
@ -56,14 +56,12 @@ function* evaluateTreeSaga(
|
||||||
PerformanceTracker.startAsyncTracking(
|
PerformanceTracker.startAsyncTracking(
|
||||||
PerformanceTransactionName.DATA_TREE_EVALUATION,
|
PerformanceTransactionName.DATA_TREE_EVALUATION,
|
||||||
);
|
);
|
||||||
const overrideUpdate = localStorage.getItem("shouldOverrideUpdate") || false;
|
|
||||||
const workerResponse = yield call(
|
const workerResponse = yield call(
|
||||||
worker.request,
|
worker.request,
|
||||||
EVAL_WORKER_ACTIONS.EVAL_TREE,
|
EVAL_WORKER_ACTIONS.EVAL_TREE,
|
||||||
{
|
{
|
||||||
unevalTree,
|
unevalTree,
|
||||||
widgetTypeConfigMap,
|
widgetTypeConfigMap,
|
||||||
overrideUpdate,
|
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
const {
|
const {
|
||||||
|
|
|
||||||
|
|
@ -123,7 +123,6 @@ export default class DataTreeEvaluator {
|
||||||
updateDataTree(
|
updateDataTree(
|
||||||
unEvalTree: DataTree,
|
unEvalTree: DataTree,
|
||||||
): {
|
): {
|
||||||
dataTree: DataTree;
|
|
||||||
updates: Diff<DataTree, DataTree>[];
|
updates: Diff<DataTree, DataTree>[];
|
||||||
evaluationOrder: string[];
|
evaluationOrder: string[];
|
||||||
unEvalUpdates: DataTreeDiff[];
|
unEvalUpdates: DataTreeDiff[];
|
||||||
|
|
@ -137,7 +136,6 @@ export default class DataTreeEvaluator {
|
||||||
// We want to check if no diffs are present and bail out early
|
// We want to check if no diffs are present and bail out early
|
||||||
if (differences.length === 0) {
|
if (differences.length === 0) {
|
||||||
return {
|
return {
|
||||||
dataTree: this.evalTree,
|
|
||||||
updates: [],
|
updates: [],
|
||||||
evaluationOrder: [],
|
evaluationOrder: [],
|
||||||
unEvalUpdates: [],
|
unEvalUpdates: [],
|
||||||
|
|
@ -188,7 +186,6 @@ export default class DataTreeEvaluator {
|
||||||
sortedDependencies: this.sortedDependencies,
|
sortedDependencies: this.sortedDependencies,
|
||||||
inverse: this.inverseDependencyMap,
|
inverse: this.inverseDependencyMap,
|
||||||
updatedDependencyMap: this.dependencyMap,
|
updatedDependencyMap: this.dependencyMap,
|
||||||
evaluationOrder,
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// Remove any deleted paths from the eval tree
|
// Remove any deleted paths from the eval tree
|
||||||
|
|
@ -223,7 +220,6 @@ export default class DataTreeEvaluator {
|
||||||
};
|
};
|
||||||
this.logs.push({ timeTakenForSubTreeEval });
|
this.logs.push({ timeTakenForSubTreeEval });
|
||||||
return {
|
return {
|
||||||
dataTree: this.evalTree,
|
|
||||||
updates: evaluationChanges || [],
|
updates: evaluationChanges || [],
|
||||||
evaluationOrder,
|
evaluationOrder,
|
||||||
unEvalUpdates: translatedDiffs,
|
unEvalUpdates: translatedDiffs,
|
||||||
|
|
|
||||||
|
|
@ -46,7 +46,7 @@ ctx.addEventListener(
|
||||||
messageEventListener((method, requestData: any) => {
|
messageEventListener((method, requestData: any) => {
|
||||||
switch (method) {
|
switch (method) {
|
||||||
case EVAL_WORKER_ACTIONS.EVAL_TREE: {
|
case EVAL_WORKER_ACTIONS.EVAL_TREE: {
|
||||||
const { overrideUpdate, unevalTree, widgetTypeConfigMap } = requestData;
|
const { unevalTree, widgetTypeConfigMap } = requestData;
|
||||||
let dataTree: DataTree = unevalTree;
|
let dataTree: DataTree = unevalTree;
|
||||||
let errors: EvalError[] = [];
|
let errors: EvalError[] = [];
|
||||||
let logs: any[] = [];
|
let logs: any[] = [];
|
||||||
|
|
@ -65,9 +65,6 @@ ctx.addEventListener(
|
||||||
} else {
|
} else {
|
||||||
dataTree = {};
|
dataTree = {};
|
||||||
const updateResponse = dataTreeEvaluator.updateDataTree(unevalTree);
|
const updateResponse = dataTreeEvaluator.updateDataTree(unevalTree);
|
||||||
if (overrideUpdate) {
|
|
||||||
dataTree = JSON.parse(JSON.stringify(updateResponse.dataTree));
|
|
||||||
}
|
|
||||||
updates = JSON.parse(JSON.stringify(updateResponse.updates));
|
updates = JSON.parse(JSON.stringify(updateResponse.updates));
|
||||||
evaluationOrder = updateResponse.evaluationOrder;
|
evaluationOrder = updateResponse.evaluationOrder;
|
||||||
unEvalUpdates = updateResponse.unEvalUpdates;
|
unEvalUpdates = updateResponse.unEvalUpdates;
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user