Revert "Hotfix for logging and debugging redux updates (#6728)"

This reverts commit 4b5ca10e0d.
This commit is contained in:
hetunandu 2021-08-19 18:31:37 +05:30
parent e76d8c2c15
commit 9941c253f7
4 changed files with 1 additions and 12 deletions

View File

@ -3,7 +3,6 @@ import { applyChange, Diff } from "deep-diff";
import { DataTree } from "entities/DataTree/dataTreeFactory";
import { createImmerReducer } from "utils/AppsmithUtils";
import * as Sentry from "@sentry/react";
import log from "loglevel";
export type EvaluatedTreeState = DataTree;
@ -30,7 +29,6 @@ const evaluatedTreeReducer = createImmerReducer(initialState, {
try {
applyChange(state, undefined, update);
} catch (e) {
log.error(e);
Sentry.captureException(e, {
extra: {
update,

View File

@ -56,14 +56,12 @@ function* evaluateTreeSaga(
PerformanceTracker.startAsyncTracking(
PerformanceTransactionName.DATA_TREE_EVALUATION,
);
const overrideUpdate = localStorage.getItem("shouldOverrideUpdate") || false;
const workerResponse = yield call(
worker.request,
EVAL_WORKER_ACTIONS.EVAL_TREE,
{
unevalTree,
widgetTypeConfigMap,
overrideUpdate,
},
);
const {

View File

@ -123,7 +123,6 @@ export default class DataTreeEvaluator {
updateDataTree(
unEvalTree: DataTree,
): {
dataTree: DataTree;
updates: Diff<DataTree, DataTree>[];
evaluationOrder: string[];
unEvalUpdates: DataTreeDiff[];
@ -137,7 +136,6 @@ export default class DataTreeEvaluator {
// We want to check if no diffs are present and bail out early
if (differences.length === 0) {
return {
dataTree: this.evalTree,
updates: [],
evaluationOrder: [],
unEvalUpdates: [],
@ -188,7 +186,6 @@ export default class DataTreeEvaluator {
sortedDependencies: this.sortedDependencies,
inverse: this.inverseDependencyMap,
updatedDependencyMap: this.dependencyMap,
evaluationOrder,
});
// Remove any deleted paths from the eval tree
@ -223,7 +220,6 @@ export default class DataTreeEvaluator {
};
this.logs.push({ timeTakenForSubTreeEval });
return {
dataTree: this.evalTree,
updates: evaluationChanges || [],
evaluationOrder,
unEvalUpdates: translatedDiffs,

View File

@ -46,7 +46,7 @@ ctx.addEventListener(
messageEventListener((method, requestData: any) => {
switch (method) {
case EVAL_WORKER_ACTIONS.EVAL_TREE: {
const { overrideUpdate, unevalTree, widgetTypeConfigMap } = requestData;
const { unevalTree, widgetTypeConfigMap } = requestData;
let dataTree: DataTree = unevalTree;
let errors: EvalError[] = [];
let logs: any[] = [];
@ -65,9 +65,6 @@ ctx.addEventListener(
} else {
dataTree = {};
const updateResponse = dataTreeEvaluator.updateDataTree(unevalTree);
if (overrideUpdate) {
dataTree = JSON.parse(JSON.stringify(updateResponse.dataTree));
}
updates = JSON.parse(JSON.stringify(updateResponse.updates));
evaluationOrder = updateResponse.evaluationOrder;
unEvalUpdates = updateResponse.unEvalUpdates;