From 93b24a145aa2e0a11d8cae0229e0c13dd143a782 Mon Sep 17 00:00:00 2001 From: Jacques Ikot Date: Thu, 14 Dec 2023 12:47:53 +0100 Subject: [PATCH] fix: update event name for template fork from canvas starter templates (#29622) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description There was a typo in the event name for fork_APPLICATIONTEMPLATE. The even has been named correctly. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed ## Summary by CodeRabbit - **Bug Fixes** - Corrected a typo in the analytics event name for forking application templates. --- app/client/src/ce/utils/analyticsUtilTypes.ts | 2 +- .../common/dropTarget/starterBuildingBlocks/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/client/src/ce/utils/analyticsUtilTypes.ts b/app/client/src/ce/utils/analyticsUtilTypes.ts index d4b82fbb37..a91b94d5b9 100644 --- a/app/client/src/ce/utils/analyticsUtilTypes.ts +++ b/app/client/src/ce/utils/analyticsUtilTypes.ts @@ -342,7 +342,7 @@ export type EventName = | "TIME_TO_NAVIGATE_ENTITY_EXPLORER" | "TEMPLATES_SEARCH_INPUT_EVENT" | "GET_STARTED_CLICKED" - | "fork_APLICATIONTEMPLATE" + | "fork_APPLICATIONTEMPLATE" | "DATA_FETCH_FAILED_POST_SCHEMA_FETCH" | "STARTER_BUILDING_BLOCK_HOVER" | "STARTER_BUILDING_BLOCK_CONNECT_DATA_CLICK" diff --git a/app/client/src/layoutSystems/common/dropTarget/starterBuildingBlocks/index.tsx b/app/client/src/layoutSystems/common/dropTarget/starterBuildingBlocks/index.tsx index 2cb5121b1e..7aa54e4205 100644 --- a/app/client/src/layoutSystems/common/dropTarget/starterBuildingBlocks/index.tsx +++ b/app/client/src/layoutSystems/common/dropTarget/starterBuildingBlocks/index.tsx @@ -83,7 +83,7 @@ function StarterBuildingBlocks() { ), ); - AnalyticsUtil.logEvent("fork_APLICATIONTEMPLATE", { + AnalyticsUtil.logEvent("fork_APPLICATIONTEMPLATE", { applicationId: currentApplication?.id, workspaceId: currentWorkSpace.id, source: "canvas",