From 92a8df8f0453eedd4ecc1d327abce64697faf8e2 Mon Sep 17 00:00:00 2001
From: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
Date: Fri, 18 Feb 2022 19:27:38 +0530
Subject: [PATCH] fix: push js object after creation (#11123)

---
 .../Explorer/JSActions/JSActionEntity.tsx       |  8 +++++---
 .../entityReducers/jsActionsReducer.tsx         | 17 ++---------------
 2 files changed, 7 insertions(+), 18 deletions(-)

diff --git a/app/client/src/pages/Editor/Explorer/JSActions/JSActionEntity.tsx b/app/client/src/pages/Editor/Explorer/JSActions/JSActionEntity.tsx
index d67ee5c9c2..e284a215a7 100644
--- a/app/client/src/pages/Editor/Explorer/JSActions/JSActionEntity.tsx
+++ b/app/client/src/pages/Editor/Explorer/JSActions/JSActionEntity.tsx
@@ -35,9 +35,11 @@ export const ExplorerJSCollectionEntity = memo(
       getJSCollection(state, props.id),
     ) as JSCollection;
     const navigateToJSCollection = useCallback(() => {
-      history.push(
-        JS_COLLECTION_ID_URL(applicationId, pageId, jsAction.id, {}),
-      );
+      if (jsAction.id) {
+        history.push(
+          JS_COLLECTION_ID_URL(applicationId, pageId, jsAction.id, {}),
+        );
+      }
     }, [pageId]);
     const contextMenu = (
       <JSCollectionEntityContextMenu
diff --git a/app/client/src/reducers/entityReducers/jsActionsReducer.tsx b/app/client/src/reducers/entityReducers/jsActionsReducer.tsx
index e6b3bb8377..1b8bf1f56a 100644
--- a/app/client/src/reducers/entityReducers/jsActionsReducer.tsx
+++ b/app/client/src/reducers/entityReducers/jsActionsReducer.tsx
@@ -40,29 +40,16 @@ const jsActionsReducer = createReducer(initialState, {
     });
   },
   [ReduxActionErrorTypes.FETCH_JS_ACTIONS_ERROR]: () => initialState,
-  [ReduxActionTypes.CREATE_JS_ACTION_INIT]: (
+  [ReduxActionTypes.CREATE_JS_ACTION_SUCCESS]: (
     state: JSCollectionDataState,
     action: ReduxAction<JSCollection>,
   ): JSCollectionDataState =>
     state.concat([
       {
-        config: { ...action.payload, id: action.payload.name },
+        config: { ...action.payload },
         isLoading: false,
       },
     ]),
-  [ReduxActionTypes.CREATE_JS_ACTION_SUCCESS]: (
-    state: JSCollectionDataState,
-    action: ReduxAction<JSCollection>,
-  ): JSCollectionDataState =>
-    state.map((a) => {
-      if (
-        a.config.pageId === action.payload.pageId &&
-        a.config.id === action.payload.name
-      ) {
-        return { ...a, config: action.payload };
-      }
-      return a;
-    }),
   [ReduxActionErrorTypes.CREATE_JS_ACTION_ERROR]: (
     state: JSCollectionDataState,
     action: ReduxAction<JSCollection>,