Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: git pkg - adding baseIds in package based urls (#38827)

Browse Source 
## Description
- Renames url param `packageId` to `basePackageId`
- Renames url param `moduleId` to `baseModuleId`
- Modifies package init sagas to use basePackageId instead of packageId


Fixes https://github.com/appsmithorg/appsmith/issues/38504
Fixes https://github.com/appsmithorg/appsmith/issues/38503
Fixes https://github.com/appsmithorg/appsmith/issues/38502

## Automation

/ok-to-test tags="@tag.Module"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13010301792>
> Commit: 3e762e2f8dd9851157041830d25983de53ab08af
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13010301792&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Module`
> Spec:
> <hr>Tue, 28 Jan 2025 12:49:42 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Added `baseId` property to Module and Package interfaces
- Updated navigation entity matching to use `basePackageId` and
`baseModuleId`

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Rudraprasad Das 2025-01-29 11:43:11 +01:00 committed by GitHub
parent 754d3efcf1
commit 927383b82a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/client/src/ce/constants/ModuleConstants.ts
View File

@ -20,6 +20,7 @@ export interface ModuleInputSection {
export interface Module export interface Module
extends Pick<ModuleMetadata, "pluginId" | "pluginType" | "datasourceId"> { extends Pick<ModuleMetadata, "pluginId" | "pluginType" | "datasourceId"> {
id: ID; id: ID;
baseId: ID;
name: string; name: string;
packageId: ID; packageId: ID;
inputsForm: ModuleInputSection[]; inputsForm: ModuleInputSection[];

1
app/client/src/ce/constants/PackageConstants.ts
View File

@ -2,6 +2,7 @@ type ID = string;
export interface Package { export interface Package {
id: ID; id: ID;
baseId: ID;
name: string; // Name of the package. name: string; // Name of the package.
icon: string; icon: string;
color: string; color: string;

4
app/client/src/navigation/FocusEntity.ts
View File

@ -63,8 +63,8 @@ export interface MatchEntityFromPath {
baseApplicationId?: string; baseApplicationId?: string;
customSlug?: string; customSlug?: string;
applicationSlug?: string; applicationSlug?: string;
packageId?: string; basePackageId?: string;
moduleId?: string; baseModuleId?: string;
workflowId?: string; workflowId?: string;
pageSlug?: string; pageSlug?: string;
baseApiId?: string; baseApiId?: string;