chore: git pkg - adding baseIds in package based urls (#38827)
## Description - Renames url param `packageId` to `basePackageId` - Renames url param `moduleId` to `baseModuleId` - Modifies package init sagas to use basePackageId instead of packageId Fixes https://github.com/appsmithorg/appsmith/issues/38504 Fixes https://github.com/appsmithorg/appsmith/issues/38503 Fixes https://github.com/appsmithorg/appsmith/issues/38502 ## Automation /ok-to-test tags="@tag.Module" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13010301792> > Commit: 3e762e2f8dd9851157041830d25983de53ab08af > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13010301792&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Module` > Spec: > <hr>Tue, 28 Jan 2025 12:49:42 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added `baseId` property to Module and Package interfaces - Updated navigation entity matching to use `basePackageId` and `baseModuleId` <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
parent
754d3efcf1
commit
927383b82a
|
|
@ -20,6 +20,7 @@ export interface ModuleInputSection {
|
|||
export interface Module
|
||||
extends Pick<ModuleMetadata, "pluginId" | "pluginType" | "datasourceId"> {
|
||||
id: ID;
|
||||
baseId: ID;
|
||||
name: string;
|
||||
packageId: ID;
|
||||
inputsForm: ModuleInputSection[];
|
||||
|
|
|
|||
|
|
@ -2,6 +2,7 @@ type ID = string;
|
|||
|
||||
export interface Package {
|
||||
id: ID;
|
||||
baseId: ID;
|
||||
name: string; // Name of the package.
|
||||
icon: string;
|
||||
color: string;
|
||||
|
|
|
|||
|
|
@ -63,8 +63,8 @@ export interface MatchEntityFromPath {
|
|||
baseApplicationId?: string;
|
||||
customSlug?: string;
|
||||
applicationSlug?: string;
|
||||
packageId?: string;
|
||||
moduleId?: string;
|
||||
basePackageId?: string;
|
||||
baseModuleId?: string;
|
||||
workflowId?: string;
|
||||
pageSlug?: string;
|
||||
baseApiId?: string;
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user