Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: Updating the settings icon throughout the product (#37330)

Browse Source 
## Description

Updating the settings icon throughout the product to use the below icon:

https://www.figma.com/design/8L9BXMzNTKboGWlHpdXyYP/Appsmith-IDE?node-id=33-3546&t=qpptzxhkWatrFIn1-4


Fixes [#37248](https://github.com/appsmithorg/appsmith/issues/37248)

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11796204902>
> Commit: 0e57343a6c2b7543f37e37940f8447be10ccd9e9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11796204902&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 12 Nov 2024 12:12:33 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Updated icons for various settings-related components from
"settings-2-line" to "settings-v3" to enhance visual representation.

- **Bug Fixes**
- Improved handling of frame ancestor settings in the AdminSettings
configuration, ensuring better management of stored values.

- **Documentation**
	- No changes to the documentation were made in this release. 

- **Chores**
- Updated multiple components to reflect the new icon, maintaining
overall functionality without introducing new logic.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Ankita Kinger 2024-11-12 18:17:58 +05:30 committed by GitHub
parent 5af1bbe9f6
commit 91cf54ba47
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
13 changed files with 16 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app/client/packages/design-system/ads/src/__assets__/icons/ads/settings-v3-icon.svg
View File

@ -1,21 +1,3 @@
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
viewBox="0 0 24 24" style="enable-background:new 0 0 24 24;" xml:space="preserve">
<style type="text/css">
.st0{fill:currentColor;}
.st1{fill-rule:evenodd;clip-rule:evenodd;fill:currentColor;}
</style>
<g>
<path class="st0" d="M14,24h-4c-1.1,0-2-0.9-2-2v-1.9c-0.3-0.2-0.7-0.4-1-0.6l-1.7,1c-0.5,0.3-1,0.3-1.5,0.2
c-0.5-0.1-0.9-0.5-1.2-0.9l-2-3.5c-0.3-0.5-0.3-1-0.2-1.5c0.1-0.5,0.5-0.9,0.9-1.2l1.7-1c0-0.2,0-0.4,0-0.6s0-0.4,0-0.6l-1.7-1
c-1-0.6-1.3-1.8-0.7-2.7l2-3.5c0.3-0.5,0.7-0.8,1.2-0.9c0.5-0.1,1.1-0.1,1.5,0.2l1.7,1c0.3-0.2,0.6-0.4,1-0.6V2c0-1.1,0.9-2,2-2h4
c1.1,0,2,0.9,2,2v1.9c0.3,0.2,0.7,0.4,1,0.6l1.7-1c1-0.6,2.2-0.2,2.7,0.7l2,3.5c0.3,0.5,0.3,1,0.2,1.5c-0.1,0.5-0.5,0.9-0.9,1.2
l-1.7,1c0,0.2,0,0.4,0,0.6c0,0.2,0,0.4,0,0.6l1.7,1c0.5,0.3,0.8,0.7,0.9,1.2c0.1,0.5,0.1,1.1-0.2,1.5l-2,3.5
c-0.3,0.5-0.7,0.8-1.2,0.9c-0.5,0.1-1.1,0.1-1.5-0.2l-1.7-1c-0.3,0.2-0.6,0.4-1,0.6V22C16,23.1,15.1,24,14,24z M7.2,17.1l0.5,0.4
c0.5,0.4,1.1,0.7,1.7,1l0.6,0.3V22h4v-3.3l0.6-0.3c0.6-0.2,1.2-0.6,1.7-1l0.5-0.4l2.8,1.6l2-3.5l-2.8-1.6l0.1-0.7
c0-0.3,0.1-0.6,0.1-1s0-0.7-0.1-1l-0.1-0.7l2.8-1.6l-2-3.5l-2.8,1.6l-0.5-0.4c-0.5-0.4-1.1-0.7-1.7-1L14,5.3V2h-4v3.3L9.4,5.5
c-0.6,0.2-1.2,0.6-1.7,1L7.2,6.9L4.3,5.3l-2,3.5l2.8,1.6L5.1,11C5,11.3,5,11.7,5,12s0,0.7,0.1,1l0.1,0.7l-2.8,1.6l2,3.5L7.2,17.1z"
/>
</g>
<path class="st1" d="M12,10c-1.1,0-2,0.9-2,2s0.9,2,2,2s2-0.9,2-2S13.1,10,12,10z M8,12c0-2.2,1.8-4,4-4c2.2,0,4,1.8,4,4
c0,2.2-1.8,4-4,4C9.8,16,8,14.2,8,12z"/>
</svg>
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none">
<path fill-rule="evenodd" clip-rule="evenodd" d="M8.65637 1.23949C8.83848 0.511032 9.493 0 10.2439 0H13.7558C14.5066 0 15.1611 0.51103 15.3433 1.23949L15.928 3.57835C15.928 3.57835 15.9306 3.58296 15.9349 3.58789C15.9441 3.59863 15.9619 3.6142 15.9897 3.62747C16.432 3.83857 16.8548 4.08358 17.2547 4.35906C17.2798 4.37639 17.302 4.38399 17.3158 4.38661C17.3221 4.3878 17.3274 4.38778 17.3274 4.38778L19.647 3.72424C20.3689 3.51773 21.1387 3.82905 21.5142 4.47932L23.2701 7.5207C23.6455 8.17097 23.5302 8.99332 22.9904 9.51526L21.2558 11.1925C21.2558 11.1925 21.2531 11.1971 21.251 11.2032C21.2463 11.2164 21.2418 11.2394 21.2442 11.2698C21.263 11.5109 21.2725 11.7545 21.2725 12C21.2725 12.2456 21.263 12.4891 21.2442 12.7302C21.2418 12.7606 21.2463 12.7836 21.251 12.7969C21.2531 12.8029 21.2558 12.8075 21.2558 12.8075L22.9904 14.4847C23.5302 15.0066 23.6455 15.829 23.27 16.4793L21.5141 19.5206C21.1387 20.1709 20.3688 20.4822 19.6469 20.2757L17.3275 19.6122C17.3275 19.6122 17.3222 19.6122 17.3159 19.6134C17.3021 19.616 17.2799 19.6236 17.2547 19.6409C16.8548 19.9164 16.432 20.1614 15.9897 20.3726C15.9619 20.3858 15.9441 20.4014 15.9349 20.4121C15.9306 20.4171 15.928 20.4217 15.928 20.4217L15.3433 22.7605C15.1611 23.489 14.5066 24 13.7558 24H10.2439C9.493 24 8.83848 23.489 8.65637 22.7605L8.07165 20.4217C8.07165 20.4217 8.06902 20.4171 8.06478 20.4121C8.05554 20.4014 8.03773 20.3858 8.00993 20.3726C7.56764 20.1615 7.14487 19.9165 6.74498 19.641C6.71981 19.6236 6.69761 19.616 6.68381 19.6134C6.67749 19.6122 6.67223 19.6122 6.67223 19.6122L4.35265 20.2758C3.63073 20.4823 2.86091 20.171 2.48547 19.5207L0.72953 16.4793C0.354094 15.8291 0.469401 15.0067 1.0092 14.4848L2.74388 12.8075C2.74388 12.8075 2.74653 12.8029 2.74867 12.7969C2.75331 12.7836 2.75785 12.7607 2.75548 12.7303C2.73666 12.4891 2.72709 12.2456 2.72709 12C2.72709 11.7545 2.73666 11.5109 2.75548 11.2698C2.75785 11.2394 2.75331 11.2164 2.74867 11.2032C2.74653 11.1971 2.74387 11.1925 2.74387 11.1925L1.00928 9.51534C0.469476 8.99339 0.354169 8.17105 0.729606 7.52077L2.48555 4.4794C2.86098 3.82912 3.63081 3.51781 4.35273 3.72432L6.67218 4.38782C6.67218 4.38782 6.67744 4.38784 6.68375 4.38665C6.69755 4.38403 6.71975 4.37643 6.74492 4.3591C7.14483 4.0836 7.56762 3.83858 8.00993 3.62747C8.03773 3.6142 8.05554 3.59863 8.06478 3.58789C8.06902 3.58297 8.07165 3.57835 8.07165 3.57835L8.65637 1.23949ZM10.6698 2.18182L10.188 4.10881C10.0142 4.80406 9.52358 5.3226 8.94974 5.5965C8.61193 5.75773 8.2887 5.94503 7.98268 6.15584C7.45811 6.51721 6.7629 6.68311 6.07337 6.48586L4.16212 5.93913L2.83206 8.24286L4.26142 9.62493C4.77592 10.1224 4.98014 10.8057 4.93068 11.4395C4.91627 11.6242 4.90891 11.8112 4.90891 12C4.90891 12.1889 4.91627 12.3758 4.93068 12.5605C4.98014 13.1943 4.77592 13.8776 4.26142 14.3751L2.83198 15.7572L4.16204 18.061L6.07343 17.5142C6.76295 17.317 7.45816 17.4829 7.98272 17.8442C8.28873 18.055 8.61194 18.2423 8.94974 18.4035C9.52357 18.6774 10.0142 19.196 10.188 19.8912L10.6698 21.8182H13.3299L13.8116 19.8912C13.9854 19.196 14.4761 18.6774 15.0499 18.4035C15.3877 18.2423 15.7109 18.055 16.017 17.8442C16.5415 17.4828 17.2367 17.3169 17.9263 17.5142L19.8375 18.0609L21.1676 15.7572L19.7382 14.3751C19.2237 13.8776 19.0195 13.1943 19.069 12.5605C19.0834 12.3758 19.0907 12.1889 19.0907 12C19.0907 11.8112 19.0834 11.6242 19.069 11.4395C19.0195 10.8057 19.2237 10.1224 19.7382 9.62493L21.1677 8.24278L19.8376 5.93905L17.9262 6.48582C17.2367 6.68307 16.5415 6.51717 16.0169 6.15581C15.7109 5.94501 15.3877 5.75773 15.0499 5.5965C14.4761 5.32261 13.9854 4.80406 13.8116 4.10881L13.3299 2.18182H10.6698ZM11.9998 9.8182C10.7948 9.8182 9.818 10.795 9.818 12C9.818 13.205 10.7948 14.1818 11.9998 14.1818C13.2048 14.1818 14.1816 13.205 14.1816 12C14.1816 10.795 13.2048 9.8182 11.9998 9.8182ZM7.63618 12C7.63618 9.59004 9.58985 7.63638 11.9998 7.63638C14.4098 7.63638 16.3635 9.59004 16.3635 12C16.3635 14.41 14.4098 16.3637 11.9998 16.3637C9.58985 16.3637 7.63618 14.41 7.63618 12Z" fill="currentColor"/>
</svg>
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 1.6 KiB

After

Width:  |  Height:  |  Size: 4.0 KiB

4
app/client/packages/dsl/src/migrate/helpers/widget-configs.json
View File

@ -7311,7 +7311,7 @@
"controlType": "OPEN_CONFIG_PANEL",
"buttonConfig": {
"label": "Configure",
"icon": "settings-2-line"
"icon": "settings-v3"
},
"label": "Configure menu items",
"isBindProperty": false,
@ -47874,7 +47874,7 @@
"controlType": "OPEN_CONFIG_PANEL",
"buttonConfig": {
"label": "Configure",
"icon": "settings-2-line"
"icon": "settings-v3"
},
"label": "Configure menu items",
"isBindProperty": false,

2
app/client/src/IDE/Components/ToolbarSettingsPopover.tsx
View File

@ -45,7 +45,7 @@ export const ToolbarSettingsPopover = (props: Props) => {
<ToggleButton
data-testid={props.dataTestId}
disabled={props.disabled}
icon="settings-2-line"
icon="settings-v3"
isSelected={isOpen}
onClick={handleButtonClick}
size="md"

2
app/client/src/ce/pages/AdminSettings/config/general.tsx
View File

@ -181,7 +181,7 @@ export const APPSMITH_ALLOWED_FRAME_ANCESTORS_SETTING: Setting = {
};
export const config: AdminConfigType = {
icon: "settings-2-line",
icon: "settings-v3",
type: SettingCategories.GENERAL,
categoryType: CategoryType.GENERAL,
controlType: SettingTypes.GROUP,

2
app/client/src/ce/pages/Applications/WorkspaceMenu.tsx
View File

@ -144,7 +144,7 @@ function WorkspaceMenu({
})
}
>
<Icon name="settings-2-line" size="md" />
<Icon name="settings-v3" size="md" />
Settings
</CustomMenuItem>
</>

2
app/client/src/components/propertyControls/DraggableListCard.tsx
View File

@ -205,7 +205,7 @@ export function DraggableListCard(props: RenderComponentProps) {
}}
onFocus={(e) => e.stopPropagation()}
size="sm"
startIcon="settings-2-line"
startIcon="settings-v3"
/>
)}
{showDelete && (

2
app/client/src/modules/ui-builder/ui/wds/WDSMenuButtonWidget/config/propertyPaneConfig/contentConfig.ts
View File

@ -88,7 +88,7 @@ export const propertyPaneContentConfig = [
controlType: "OPEN_CONFIG_PANEL",
buttonConfig: {
label: "Configure",
icon: "settings-2-line",
icon: "settings-v3",
},
label: "Configure menu items",
isBindProperty: false,

2
app/client/src/pages/Editor/AppSettingsPane/AppSettings/index.tsx
View File

@ -126,7 +126,7 @@ function AppSettings() {
const SectionHeadersConfig: SectionHeaderProps[] = [
{
id: "t--general-settings-header",
icon: "settings-2-line",
icon: "settings-v3",
isSelected: selectedTab.type === AppSettingsTabs.General,
name: createMessage(GENERAL_SETTINGS_SECTION_HEADER),
onClick: () => {

2
app/client/src/pages/Editor/gitSync/QuickGitActions/index.tsx
View File

@ -215,7 +215,7 @@ const getQuickActionButtons = ({
},
{
className: "t--bottom-git-settings",
icon: "settings-2-line",
icon: "settings-v3",
onClick: settings,
tooltipText: createMessage(GIT_SETTINGS),
},

2
app/client/src/pages/Editor/gitSync/components/GitChangesList/StaticChange.tsx
View File

@ -49,7 +49,7 @@ const allStaticChangeDefs: Record<
[StaticChangeKind.SETTINGS]: (status: GitStatusData) => ({
condition: status.modified.includes("application.json"),
message: "Application settings modified",
iconName: "settings-2-line",
iconName: "settings-v3",
}),
[StaticChangeKind.THEME]: (status: GitStatusData) => ({
condition: status.modified.includes("theme.json"),

2
app/client/src/pages/common/SearchBar/HomepageHeaderAction.tsx
View File

@ -92,7 +92,7 @@ const HomepageHeaderAction = ({
});
}}
size="md"
startIcon="settings-control"
startIcon="settings-v3"
/>
</Tooltip>
)}

2
app/client/src/widgets/MenuButtonWidget/widget/propertyConfig/contentConfig.ts
View File

@ -89,7 +89,7 @@ export default [
controlType: "OPEN_CONFIG_PANEL",
buttonConfig: {
label: "Configure",
icon: "settings-2-line",
icon: "settings-v3",
},
label: "Configure menu items",
isBindProperty: false,

2
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Basic.ts
View File

@ -181,7 +181,7 @@ export default {
controlType: "OPEN_CONFIG_PANEL",
buttonConfig: {
label: "Configure",
icon: "settings-2-line",
icon: "settings-v3",
},
label: "Configure menu items",
isBindProperty: false,