From 8c84dcfdecd34af076c7a55b1a5660c104383ac8 Mon Sep 17 00:00:00 2001 From: Hetu Nandu Date: Wed, 2 Jun 2021 18:27:27 +0530 Subject: [PATCH] Fix multiline js issues (#4816) --- app/client/src/workers/evaluate.test.ts | 5 ----- app/client/src/workers/evaluate.ts | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/app/client/src/workers/evaluate.test.ts b/app/client/src/workers/evaluate.test.ts index d658e35fc4..d708ce2952 100644 --- a/app/client/src/workers/evaluate.test.ts +++ b/app/client/src/workers/evaluate.test.ts @@ -34,11 +34,6 @@ describe("evaluate", () => { const response = evaluate(js, {}); expect(response.result).toBe("Hello!"); }); - it("unescapes string and removes linebreaks before evaluation", () => { - const js = "'Hello,\\nworld!'"; - const response = evaluate(js, {}); - expect(response.result).toBe("Hello,world!"); - }); it("throws error for undefined js", () => { // eslint-disable-next-line @typescript-eslint/ban-ts-comment // @ts-ignore diff --git a/app/client/src/workers/evaluate.ts b/app/client/src/workers/evaluate.ts index 6e182f1d88..37d9b91465 100644 --- a/app/client/src/workers/evaluate.ts +++ b/app/client/src/workers/evaluate.ts @@ -17,7 +17,7 @@ export default function evaluate( data: DataTree, callbackData?: Array, ): EvalResult { - const unescapedJS = unescapeJS(js).replace(/(\r\n|\n|\r)/gm, ""); + const unescapedJS = unescapeJS(js); const scriptToEvaluate = ` const result = ${unescapedJS}; return { result, triggers: self.triggers }