Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix multiline js issues (#4816)

Browse Source
This commit is contained in:
Hetu Nandu 2021-06-02 18:27:27 +05:30 committed by GitHub
parent 77940c0cfa
commit 8c84dcfdec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/client/src/workers/evaluate.test.ts
View File

@ -34,11 +34,6 @@ describe("evaluate", () => {
const response = evaluate(js, {});
expect(response.result).toBe("Hello!");
});
it("unescapes string and removes linebreaks before evaluation", () => {
const js = "'Hello,\\nworld!'";
const response = evaluate(js, {});
expect(response.result).toBe("Hello,world!");
});
it("throws error for undefined js", () => {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore

2
app/client/src/workers/evaluate.ts
View File

@ -17,7 +17,7 @@ export default function evaluate(
data: DataTree,
callbackData?: Array<any>,
): EvalResult {
const unescapedJS = unescapeJS(js).replace(/(\r\n|\n|\r)/gm, "");
const unescapedJS = unescapeJS(js);
const scriptToEvaluate = `
const result = ${unescapedJS};
return { result, triggers: self.triggers }