From 8c7307b84ec72aeb86a5d145a6908e6e15eeb90f Mon Sep 17 00:00:00 2001 From: ChandanBalajiBP <104058110+ChandanBalajiBP@users.noreply.github.com> Date: Tue, 22 Aug 2023 06:29:18 +0530 Subject: [PATCH] chore: Add switch environment configuration telemetry (#26504) ## Description > Adds switch environment telemetry during datasource configuration > > #### PR fixes following issue(s) Fixes #26540 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --- app/client/src/ce/utils/analyticsUtilTypes.ts | 3 +++ app/client/src/pages/Editor/DataSourceEditor/index.tsx | 9 ++++++++- .../src/pages/Editor/SaaSEditor/DatasourceForm.tsx | 9 +++++++++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/app/client/src/ce/utils/analyticsUtilTypes.ts b/app/client/src/ce/utils/analyticsUtilTypes.ts index c1c7b5dde2..034634c814 100644 --- a/app/client/src/ce/utils/analyticsUtilTypes.ts +++ b/app/client/src/ce/utils/analyticsUtilTypes.ts @@ -293,6 +293,9 @@ export type EventName = | "TEST_DATA_SOURCE_FAILED" | "DATASOURCE_SCHEMA_FETCH" | "SWITCH_ENVIRONMENT" + | "DEPLOY_WITH_GIT_DISMISS_ENV_MESSAGE" + | "CANCEL_DEPLOY_WITHOUT_GIT" + | "DEPLOY_WITHOUT_GIT_DISMISS_ENV_MESSAGE" | "EDIT_ACTION_CLICK" | "QUERY_TEMPLATE_SELECTED" | "RUN_API_FAILURE" diff --git a/app/client/src/pages/Editor/DataSourceEditor/index.tsx b/app/client/src/pages/Editor/DataSourceEditor/index.tsx index 050e5e039e..6aabacbf5e 100644 --- a/app/client/src/pages/Editor/DataSourceEditor/index.tsx +++ b/app/client/src/pages/Editor/DataSourceEditor/index.tsx @@ -95,6 +95,7 @@ import { onUpdateFilterSuccess, } from "@appsmith/utils/Environments"; import type { CalloutKind } from "design-system"; +import AnalyticsUtil from "utils/AnalyticsUtil"; interface ReduxStateProps { canCreateDatasourceActions: boolean; @@ -610,7 +611,13 @@ class DatasourceEditorRouter extends React.Component { }, }); } - + AnalyticsUtil.logEvent("SWITCH_ENVIRONMENT", { + fromEnvId: this.state.filterParams.id, + toEnvId: id, + fromEnvName: this.state.filterParams.name, + toEnvName: name, + mode: "CONFIGURATION", + }); // This is the event that changes the filter and updates the datasource this.setState({ filterParams: { diff --git a/app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx b/app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx index 0d8115d91a..a1a676e3ac 100644 --- a/app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx +++ b/app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx @@ -87,6 +87,7 @@ import { getQueryParams } from "utils/URLUtils"; import GoogleSheetSchema from "./GoogleSheetSchema"; import { FEATURE_FLAG } from "@appsmith/entities/FeatureFlag"; import { selectFeatureFlagCheck } from "@appsmith/selectors/featureFlagsSelectors"; +import AnalyticsUtil from "utils/AnalyticsUtil"; const ViewModeContainer = styled.div` display: flex; @@ -340,6 +341,14 @@ class DatasourceSaaSEditor extends JSONtoForm { this.state.filterParams.showFilterPane === showFilterPane ) return false; + + AnalyticsUtil.logEvent("SWITCH_ENVIRONMENT", { + fromEnvId: this.state.filterParams.id, + toEnvId: id, + fromEnvName: this.state.filterParams.name, + toEnvName: name, + mode: "CONFIGURATION", + }); this.setState({ filterParams: { id,