Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix input's onSubmit action being triggered if its validation is failing (#2960)

Browse Source
This commit is contained in:
Rishabh Saxena 2021-02-10 13:13:41 +05:30 committed by GitHub
parent 4becc50005
commit 8c72e901ee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/client/src/widgets/InputWidget.tsx
View File

@ -154,10 +154,11 @@ class InputWidget extends BaseWidget<InputWidgetProps, WidgetState> {
| React.KeyboardEvent<HTMLTextAreaElement>
| React.KeyboardEvent<HTMLInputElement>,
) => {
const { isValid, onSubmit } = this.props;
const isEnterKey = e.key === "Enter" || e.keyCode === 13;
if (isEnterKey && this.props.onSubmit) {
if (isEnterKey && onSubmit && isValid) {
super.executeAction({
dynamicString: this.props.onSubmit,
dynamicString: onSubmit,
event: {
type: EventType.ON_SUBMIT,
callback: this.onSubmitSuccess,