From 8bf6df527273f6c6a4b3c776545bcb62436cec0d Mon Sep 17 00:00:00 2001
From: Valera Melnikov <valera@appsmith.com>
Date: Fri, 9 Aug 2024 20:46:25 +0300
Subject: [PATCH] fix: test storybook action (#35585)

## Description
Example of a successful pass:

https://github.com/appsmithorg/appsmith/actions/runs/10321826794/job/28575617540

## Automation

/ok-to-test tags=""

### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Streamlined GitHub Actions workflow for testing Storybook by
consolidating Playwright installation and removing redundant steps.
	- Enhanced clarity and efficiency of the testing process.
- **Style**
- Updated button component styles by disabling rounded corners,
reflecting a potential shift in design strategy.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .github/workflows/test-storybook.yml | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/test-storybook.yml b/.github/workflows/test-storybook.yml
index 20081135e4..db66846123 100644
--- a/.github/workflows/test-storybook.yml
+++ b/.github/workflows/test-storybook.yml
@@ -38,18 +38,12 @@ jobs:
 
       - name: Install Dependencies
         working-directory: ./app/client/packages/storybook
-        run: yarn install --immutable
+        run: |
+          yarn install --immutable
+          npx playwright install --with-deps
 
       - name: Storybook Tests
-        id: Test Storybook
-        uses: actions/setup-node@v4
-        with:
-          node-version-file: app/client/package.json
-
-      - name: Install Playwright
-        run: npx playwright install --with-deps
-
-      - name: Serve Storybook and run tests
-        with:
-          workingDir: ./app/client/packages/storybook
-          buildScriptName: "test-storybook:ci"
+        working-directory: ./app/client/packages/storybook
+        run: |
+          yarn build-storybook
+          yarn test-storybook:ci