fix: remove dependency on canvas in package.json (#28273)

## Description
- We added the `canvas` dependency in `package.json` to enable jest
tests to work
- As an alternative, we're mocking the `canvas` for jest tests

#### PR fixes following issue(s)
Fixes # (issue number)
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## Testing
#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest - This change works if existing tests pass
- [ ] Cypress - This change works if existing tests pass

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
Abhinav Jha 2023-10-23 18:48:33 +05:30 committed by GitHub
parent c42b368bc9
commit 8b5269fef1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 117 deletions

View File

@ -52,6 +52,7 @@ module.exports = {
"^@blueprintjs/select$": "^@blueprintjs/select$":
"<rootDir>/node_modules/@blueprintjs/select/lib/esnext", "<rootDir>/node_modules/@blueprintjs/select/lib/esnext",
"design-system": "<rootDir>/node_modules/design-system/build", "design-system": "<rootDir>/node_modules/design-system/build",
"^canvas$": "jest-canvas-mock",
}, },
globals: { globals: {
"ts-jest": { "ts-jest": {

View File

@ -288,7 +288,6 @@
"@typescript-eslint/parser": "^6.7.4", "@typescript-eslint/parser": "^6.7.4",
"babel-plugin-lodash": "^3.3.4", "babel-plugin-lodash": "^3.3.4",
"babel-plugin-module-resolver": "^4.1.0", "babel-plugin-module-resolver": "^4.1.0",
"canvas": "^2.11.2",
"chalk": "^4.1.1", "chalk": "^4.1.1",
"compression-webpack-plugin": "^10.0.0", "compression-webpack-plugin": "^10.0.0",
"cra-bundle-analyzer": "^0.1.0", "cra-bundle-analyzer": "^0.1.0",

View File

@ -4033,25 +4033,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"@mapbox/node-pre-gyp@npm:^1.0.0":
version: 1.0.11
resolution: "@mapbox/node-pre-gyp@npm:1.0.11"
dependencies:
detect-libc: ^2.0.0
https-proxy-agent: ^5.0.0
make-dir: ^3.1.0
node-fetch: ^2.6.7
nopt: ^5.0.0
npmlog: ^5.0.1
rimraf: ^3.0.2
semver: ^7.3.5
tar: ^6.1.11
bin:
node-pre-gyp: bin/node-pre-gyp
checksum: b848f6abc531a11961d780db813cc510ca5a5b6bf3184d72134089c6875a91c44d571ba6c1879470020803f7803609e7b2e6e429651c026fe202facd11d444b8
languageName: node
linkType: hard
"@mdx-js/react@npm:^2.1.5": "@mdx-js/react@npm:^2.1.5":
version: 2.3.0 version: 2.3.0
resolution: "@mdx-js/react@npm:2.3.0" resolution: "@mdx-js/react@npm:2.3.0"
@ -10480,7 +10461,6 @@ __metadata:
axios: ^0.27.2 axios: ^0.27.2
babel-plugin-lodash: ^3.3.4 babel-plugin-lodash: ^3.3.4
babel-plugin-module-resolver: ^4.1.0 babel-plugin-module-resolver: ^4.1.0
canvas: ^2.11.2
chalk: ^4.1.1 chalk: ^4.1.1
classnames: ^2.3.1 classnames: ^2.3.1
clsx: ^1.2.1 clsx: ^1.2.1
@ -10704,16 +10684,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"are-we-there-yet@npm:^2.0.0":
version: 2.0.0
resolution: "are-we-there-yet@npm:2.0.0"
dependencies:
delegates: ^1.0.0
readable-stream: ^3.6.0
checksum: 6c80b4fd04ecee6ba6e737e0b72a4b41bdc64b7d279edfc998678567ff583c8df27e27523bc789f2c99be603ffa9eaa612803da1d886962d2086e7ff6fa90c7c
languageName: node
linkType: hard
"are-we-there-yet@npm:^3.0.0": "are-we-there-yet@npm:^3.0.0":
version: 3.0.1 version: 3.0.1
resolution: "are-we-there-yet@npm:3.0.1" resolution: "are-we-there-yet@npm:3.0.1"
@ -12388,18 +12358,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"canvas@npm:^2.11.2":
version: 2.11.2
resolution: "canvas@npm:2.11.2"
dependencies:
"@mapbox/node-pre-gyp": ^1.0.0
nan: ^2.17.0
node-gyp: latest
simple-get: ^3.0.3
checksum: 61e554aef80022841dc836964534082ec21435928498032562089dfb7736215f039c7d99ee546b0cf10780232d9bf310950f8b4d489dc394e0fb6f6adfc97994
languageName: node
linkType: hard
"capital-case@npm:^1.0.4": "capital-case@npm:^1.0.4":
version: 1.0.4 version: 1.0.4
resolution: "capital-case@npm:1.0.4" resolution: "capital-case@npm:1.0.4"
@ -12958,7 +12916,7 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"color-support@npm:^1.1.2, color-support@npm:^1.1.3": "color-support@npm:^1.1.3":
version: 1.1.3 version: 1.1.3
resolution: "color-support@npm:1.1.3" resolution: "color-support@npm:1.1.3"
bin: bin:
@ -14329,15 +14287,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"decompress-response@npm:^4.2.0":
version: 4.2.1
resolution: "decompress-response@npm:4.2.1"
dependencies:
mimic-response: ^2.0.0
checksum: 4e783ca4dfe9417354d61349750fe05236f565a4415a6ca20983a311be2371debaedd9104c0b0e7b36e5f167aeaae04f84f1a0b3f8be4162f1d7d15598b8fdba
languageName: node
linkType: hard
"decompress-response@npm:^6.0.0": "decompress-response@npm:^6.0.0":
version: 6.0.0 version: 6.0.0
resolution: "decompress-response@npm:6.0.0" resolution: "decompress-response@npm:6.0.0"
@ -14687,13 +14636,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"detect-libc@npm:^2.0.0":
version: 2.0.2
resolution: "detect-libc@npm:2.0.2"
checksum: 2b2cd3649b83d576f4be7cc37eb3b1815c79969c8b1a03a40a4d55d83bc74d010753485753448eacb98784abf22f7dbd3911fd3b60e29fda28fed2d1a997944d
languageName: node
linkType: hard
"detect-newline@npm:^3.0.0": "detect-newline@npm:^3.0.0":
version: 3.1.0 version: 3.1.0
resolution: "detect-newline@npm:3.1.0" resolution: "detect-newline@npm:3.1.0"
@ -17468,23 +17410,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"gauge@npm:^3.0.0":
version: 3.0.2
resolution: "gauge@npm:3.0.2"
dependencies:
aproba: ^1.0.3 || ^2.0.0
color-support: ^1.1.2
console-control-strings: ^1.0.0
has-unicode: ^2.0.1
object-assign: ^4.1.1
signal-exit: ^3.0.0
string-width: ^4.2.3
strip-ansi: ^6.0.1
wide-align: ^1.1.2
checksum: 81296c00c7410cdd48f997800155fbead4f32e4f82109be0719c63edc8560e6579946cc8abd04205297640691ec26d21b578837fd13a4e96288ab4b40b1dc3e9
languageName: node
linkType: hard
"gauge@npm:^4.0.3": "gauge@npm:^4.0.3":
version: 4.0.4 version: 4.0.4
resolution: "gauge@npm:4.0.4" resolution: "gauge@npm:4.0.4"
@ -22179,13 +22104,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"mimic-response@npm:^2.0.0":
version: 2.1.0
resolution: "mimic-response@npm:2.1.0"
checksum: 014fad6ab936657e5f2f48bd87af62a8e928ebe84472aaf9e14fec4fcb31257a5edff77324d8ac13ddc6685ba5135cf16e381efac324e5f174fb4ddbf902bf07
languageName: node
linkType: hard
"mimic-response@npm:^3.1.0": "mimic-response@npm:^3.1.0":
version: 3.1.0 version: 3.1.0
resolution: "mimic-response@npm:3.1.0" resolution: "mimic-response@npm:3.1.0"
@ -22598,15 +22516,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"nan@npm:^2.17.0":
version: 2.18.0
resolution: "nan@npm:2.18.0"
dependencies:
node-gyp: latest
checksum: 4fe42f58456504eab3105c04a5cffb72066b5f22bd45decf33523cb17e7d6abc33cca2a19829407b9000539c5cb25f410312d4dc5b30220167a3594896ea6a0a
languageName: node
linkType: hard
"nanoid@npm:^2.0.4": "nanoid@npm:^2.0.4":
version: 2.1.11 version: 2.1.11
resolution: "nanoid@npm:2.1.11" resolution: "nanoid@npm:2.1.11"
@ -22892,18 +22801,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"npmlog@npm:^5.0.1":
version: 5.0.1
resolution: "npmlog@npm:5.0.1"
dependencies:
are-we-there-yet: ^2.0.0
console-control-strings: ^1.1.0
gauge: ^3.0.0
set-blocking: ^2.0.0
checksum: 516b2663028761f062d13e8beb3f00069c5664925871a9b57989642ebe09f23ab02145bf3ab88da7866c4e112cafff72401f61a672c7c8a20edc585a7016ef5f
languageName: node
linkType: hard
"npmlog@npm:^6.0.0": "npmlog@npm:^6.0.0":
version: 6.0.2 version: 6.0.2
resolution: "npmlog@npm:6.0.2" resolution: "npmlog@npm:6.0.2"
@ -28566,17 +28463,6 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"simple-get@npm:^3.0.3":
version: 3.1.1
resolution: "simple-get@npm:3.1.1"
dependencies:
decompress-response: ^4.2.0
once: ^1.3.1
simple-concat: ^1.0.0
checksum: 80195e70bf171486e75c31e28e5485468195cc42f85940f8b45c4a68472160144d223eb4d07bc82ef80cb974b7c401db021a540deb2d34ac4b3b8883da2d6401
languageName: node
linkType: hard
"simple-update-notifier@npm:^2.0.0": "simple-update-notifier@npm:^2.0.0":
version: 2.0.0 version: 2.0.0
resolution: "simple-update-notifier@npm:2.0.0" resolution: "simple-update-notifier@npm:2.0.0"
@ -31951,7 +31837,7 @@ __metadata:
languageName: node languageName: node
linkType: hard linkType: hard
"wide-align@npm:^1.1.0, wide-align@npm:^1.1.2, wide-align@npm:^1.1.5": "wide-align@npm:^1.1.0, wide-align@npm:^1.1.5":
version: 1.1.5 version: 1.1.5
resolution: "wide-align@npm:1.1.5" resolution: "wide-align@npm:1.1.5"
dependencies: dependencies: