Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fixes date widget crashing when no date format is mentioned (#322)

Browse Source 
Fixed by using a proper default format string for ISO dates
This commit is contained in:
Hetu Nandu 2020-08-17 10:33:15 +05:30 committed by GitHub
parent cbc4796921
commit 855fc1c00a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/src/constants/WidgetValidation.ts
View File

@ -33,3 +33,5 @@ export type Validator = (
props: WidgetProps, props: WidgetProps,
dataTree?: DataTree, dataTree?: DataTree,
) => ValidationResponse; ) => ValidationResponse;
export const ISO_DATE_FORMAT = "YYYY-MM-DDTHH:mm:ss.SSSZ";

5
app/client/src/utils/Validators.ts
View File

@ -1,5 +1,6 @@
import _ from "lodash"; import _ from "lodash";
import { import {
ISO_DATE_FORMAT,
VALIDATION_TYPES, VALIDATION_TYPES,
ValidationResponse, ValidationResponse,
ValidationType, ValidationType,
@ -392,8 +393,8 @@ export const VALIDATORS: Record<ValidationType, Validator> = {
.minute(0) .minute(0)
.second(0) .second(0)
.millisecond(0); .millisecond(0);
const dateFormat = props.dateFormat ? props.dateFormat : moment.ISO_8601; const dateFormat = props.dateFormat ? props.dateFormat : ISO_DATE_FORMAT;
// const dateStr = moment().toISOString();
const todayDateString = today.format(dateFormat); const todayDateString = today.format(dateFormat);
if (dateString === undefined) { if (dateString === undefined) {
return { return {