fix: Adding pageId check to fix private JS object deletion flow on package editor (#30687)
## Description Adding pageId check to fix private JS object deletion flow on package editor #### PR fixes following issue(s) Fixes # (issue number) #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the logic for deleting JavaScript collections to conditionally update and save layout, enhancing user experience by ensuring relevant updates are made only when necessary. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
parent
89e0055ddc
commit
85492d8cd6
|
|
@ -346,7 +346,7 @@ export function* deleteJSCollectionSaga(
|
|||
);
|
||||
if (isPagePaneSegmentsEnabled) {
|
||||
yield call(handleDeleteRedirect, id);
|
||||
} else {
|
||||
} else if (pageId) {
|
||||
history.push(builderURL({ pageId }));
|
||||
}
|
||||
yield put(removeFocusHistoryRequest(currentUrl));
|
||||
|
|
@ -364,13 +364,16 @@ export function* deleteJSCollectionSaga(
|
|||
yield put(deleteJSCollectionSuccess({ id }));
|
||||
|
||||
const widgets: CanvasWidgetsReduxState = yield select(getWidgets);
|
||||
yield put(
|
||||
updateAndSaveLayout(widgets, {
|
||||
shouldReplay: false,
|
||||
isRetry: false,
|
||||
updatedWidgetIds: [],
|
||||
}),
|
||||
);
|
||||
|
||||
if (pageId) {
|
||||
yield put(
|
||||
updateAndSaveLayout(widgets, {
|
||||
shouldReplay: false,
|
||||
isRetry: false,
|
||||
updatedWidgetIds: [],
|
||||
}),
|
||||
);
|
||||
}
|
||||
}
|
||||
} catch (error) {
|
||||
yield put(deleteJSCollectionError({ id: actionPayload.payload.id }));
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user