chore: use spybean for SessionUserService and remove unused method for populating the userId in the ActionExecuteDTO (#37268)
## Description > Fix test case for EE Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11717655239> > Commit: 87131cbe02fa4e13ef4a88288ffa64a27846c9fc > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11717655239&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 07 Nov 2024 06:49:49 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Tests** - Updated the `sessionUserService` field in the test class to utilize partial mocking, enhancing the verification of interactions during tests. - **Bug Fixes** - Removed the method responsible for populating user IDs in action execution, streamlining user identification handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
This commit is contained in:
parent
ae7f8c73ec
commit
83e75583e3
|
|
@ -265,15 +265,6 @@ public class ActionExecutionSolutionCEImpl implements ActionExecutionSolutionCE
|
||||||
}));
|
}));
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* Populates the requestParams with logged in userId.
|
|
||||||
* If the user is not logged in, set the parameter as anonymousUserId
|
|
||||||
*
|
|
||||||
*/
|
|
||||||
protected Mono<ExecuteActionDTO> populateExecuteActionDTOWithUserId(ExecuteActionDTO executeActionDTO) {
|
|
||||||
return Mono.just(executeActionDTO);
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Executes the action(queries) by creating executeActionDTO and sending it to the plugin for further execution
|
* Executes the action(queries) by creating executeActionDTO and sending it to the plugin for further execution
|
||||||
*
|
*
|
||||||
|
|
|
||||||
|
|
@ -109,7 +109,7 @@ class ActionExecutionSolutionCEImplTest {
|
||||||
@MockBean
|
@MockBean
|
||||||
ApplicationService applicationService;
|
ApplicationService applicationService;
|
||||||
|
|
||||||
@MockBean
|
@SpyBean
|
||||||
SessionUserService sessionUserService;
|
SessionUserService sessionUserService;
|
||||||
|
|
||||||
@MockBean
|
@MockBean
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user