Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

ci: Default to release CS unless building for prod (#25856)

Browse Source 
When running Appsmith release image, it's currently using production CS,
which is causing a lot of incompatibility related errors since `release`
moves much faster than prod.

This changes this. Note that for `:latest` and `:nightly` images, we do
NOT change this default. There's no change for Docker images with those
tags. We _only_ want change `:release` image, DP images, and images
built for Cypress runs.
This commit is contained in:
Shrikant Sharat Kandula 2023-08-01 07:35:01 +05:30 committed by GitHub
parent a59ba04b07
commit 818d997d5d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/ad-hoc-deploy-preview.yml vendored
View File

@ -43,7 +43,7 @@ jobs:
# }
# )'
# #TODO Add mongo URI as secret
server-build:
name: server-build
uses: ./.github/workflows/server-build.yml
@ -145,6 +145,8 @@ jobs:
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
repository: ${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-dp
tags: ${{ github.event.inputs.sub-domain-name }}
build-args: |
APPSMITH_CLOUD_SERVICES_BASE_URL=https://release-cs.appsmith.com
outputs:
imageHash: ${{ github.event.inputs.sub-domain-name }}

3
.github/workflows/build-docker-image.yml vendored
View File

@ -81,6 +81,9 @@ jobs:
if [[ "${{ inputs.pr }}" != 0 ]]; then
args+=(--cache-from "${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-${{ vars.EDITION }}:release")
fi
if [[ "${{ inputs.pr }}" != 0 || "${{ github.ref_name }}" != master ]]; then
args+=(--build-arg "APPSMITH_CLOUD_SERVICES_BASE_URL=https://release-cs.appsmith.com")
fi
docker build -t cicontainer "${args[@]}" .
# Saving the docker image to tar file

2
.github/workflows/on-demand-build-docker-image-deploy-preview.yml vendored
View File

@ -174,6 +174,8 @@ jobs:
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
repository: ${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-dp
tags: ce-${{ github.event.client_payload.pull_request.number }}
build-args: |
APPSMITH_CLOUD_SERVICES_BASE_URL=https://release-cs.appsmith.com
outputs:
imageHash: ce-${{ github.event.client_payload.pull_request.number }}

3
.github/workflows/test-build-docker-image.yml vendored
View File

@ -200,6 +200,7 @@ jobs:
platforms: linux/arm64,linux/amd64
build-args: |
APPSMITH_SEGMENT_CE_KEY=${{ secrets.APPSMITH_SEGMENT_CE_KEY_RELEASE }}
APPSMITH_CLOUD_SERVICES_BASE_URL=https://release-cs.appsmith.com
tags: |
${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-ce:release
@ -269,4 +270,4 @@ jobs:
APPSMITH_SEGMENT_CE_KEY=${{ secrets.APPSMITH_SEGMENT_CE_KEY }}
tags: |
${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-ce:${{ github.sha }}
${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-ce:nightly
${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-ce:nightly